Closed
Bug 503573
Opened 15 years ago
Closed 15 years ago
moz-icon doesn't work on Window CE
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: zpao, Assigned: Dolske)
References
Details
(Whiteboard: [nv])
Attachments
(1 file, 1 obsolete file)
|
5.43 KB,
patch
|
Details | Diff | Splinter Review |
moz-icon:// URIs don't render icons like they're supposed to on Windows CE. These are used in the download manager & when browsing file:// URIs. From what I understand, this is likely a limitation of the Windows CE API, but we'll need to look into it.
|
Reporter | |
Updated•15 years ago
|
Whiteboard: [nv]
|
Assignee | |
Comment 2•15 years ago
|
||
This doesn't look *too* bad... Most of the code that's #ifndef WINCE in modules/libpr0n/decoders/icon/win/nsIconChannel.cpp will get going with a few small tweaks. From a bit of experimentation, the two main tasks seem to be: * Implement a replacement for ::GetDIBits(), which isn't available on WinCE * Avoid usage of nsIFile.normalize(), or implement that on WinCE.
Assignee: nobody → dolske
|
|
Assignee | |
Comment 3•15 years ago
|
||
Yay, now working. Tested with icons in the download manager, and by viewing file:///Hard Disk or file:///Windows
Attachment #390985 -
Flags: review?(vladimir)
Attachment #390985 -
Flags: review?(vladimir) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Oops. Forgot to clean up stuff in the first patch.
Attachment #390985 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•15 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/95aca25829be
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•