503578 - A tag named “()” is shown as a user tag

Status: RESOLVED WORKSFORME

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[fcp]

A tag named “()” is shown as a user tag even if it was added by the author of the add-on.  I do not know any other tags which trigger the same behavior.

I am filing this bug not because this is a real issue but mainly because I am curious to know why such a thing can happen :)

Steps to reproduce:
1. Log in to preview.addons.mozilla.org.
2. Go to an add-on details page of your own add-on.
3. Add a tag named “()”.  That is, a two-character tag consisting of a left parenthesis and a right parenthesis.
4. (Optional) Add other tags and compare the icons.

Actual results:
The tag “()” is shown with the icon representing a user tag.

Expected results:
The tag “()” is shown with the icon representing a developer tag.  (Currently developer tags lack an icon; see bug 503574.)

Comment 1

[Wil Clouser [:clouserw]]

this works as expected for me... I get the class "developertag" on the surrounding <li>...

Comment 2

[fcp]

Thank you for trying.  It is strange, because I repeated the same steps many times and the behavior seems 100% reproducible for me.  I always get the “usertag” class on <li>.
https://preview.addons.mozilla.org/en-US/firefox/addon/12312

This might be specific to this add-on because I tried adding many strange tags to it (though I removed all of them after that).

Please feel free to close this bug as works-for-me.  I will try again some time after AMO 5.0.7 goes into production, and I hope that the problem will have gone away.

Comment 3

[Wil Clouser [:clouserw]]

Hmm, I was trying on https://preview.addons.mozilla.org/en-US/thunderbird/addon/5326

Let me know if you can reproduce sometime.

Comment 4

[fcp]

Just a wild guess, but is it possible that the fix of bug 503675 has also fixed this?

I suspect so because now the tags which I had added to my add-on are all correctly shown as developer tags.

Moreover, sometime between July 11 and July 13, I realized that not only the tag “()” but all of the tags were shown as user tags even though I had not touched the tags since I had added them on July 10; in other words, the icon for the tags other than “()” turned from the one for developer tags from the one for user tags even though I did nothing to them.  Therefore, the name of the tag might have had nothing to do from the beginning.

My wild and wishful guess is that (i) originally, there was an issue that some of the developer tags were consistently shown as user tags, and (ii) the fix of bug 503675 (or some other change in the code made on July 11 or later) has also fixed this issue.

Comment 5

[fcp]

(In reply to comment #4)
> Moreover, sometime between July 11 and July 13, I realized that not only the
> tag “()” but all of the tags were shown as user tags
insert: [on the details page of my add-on
https://preview.addons.mozilla.org/en-US/firefox/addon/12312]
> even though I had not
> touched the tags since I had added them on July 10; in other words, the icon
> for the tags other than “()” turned from the one for developer tags from the
> one for user tags even though I did nothing to them.  Therefore, the name of
> the tag might have had nothing to do from the beginning.