Closed
Bug 503734
Opened 16 years ago
Closed 16 years ago
MAX_HISTORY_MENU_ITEMS and GLUE_CID shouldn't be defined globally
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3.6a1
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file)
|
4.46 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
random browser.js cleanup...
Attachment #388119 -
Flags: review?(gavin.sharp)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 388119 [details] [diff] [review]
patch
>diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js
>@@ -3169,31 +3164,30 @@ function FillHistoryMenu(aParent) {
>+ var bundle_browser = document.getElementById("bundle_browser");
Pretty much all references to bundle_browser in this file should just use gNavigatorBundle, I think.
Attachment #388119 -
Flags: review?(gavin.sharp) → review+
|
Assignee | |
Comment 2•16 years ago
|
||
(In reply to comment #1)
> Pretty much all references to bundle_browser in this file should just use
> gNavigatorBundle, I think.
Yes, including browser-places.js and nsContextMenu.js. I was going to do this right after this bug.
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
You need to log in
before you can comment on or make changes to this bug.
Description
•