503744 - Fix MMOS2 stuff in os2/nsSound

Status: RESOLVED FIXED

(Core Graveyard :: Widget: OS/2, defect)

Description

[Peter Weilbacher]

There are a few problems with nsSound on OS/2:

- Apparently, MDM.DLL doesn't like to be repeatedly loaded and unloaded
  again. We should just link to MMOS2 at compile time.

- Lars Erdmann wrote to me (a long time ago) that the MP3 detection code
  should be simplified to match the MP3 data types that the IOProc
  supports.

On my system the first problem even causes annoying beeps whenever I access any menu, and apparently completely messes up the whole MMOS2 system so that I have to reboot before I can hear any normal sounds again.

Finally, I wonder if we should support the new sound properties (like EVENT_CONFIRM_DIALOG_OPEN) in some way. We don't have any property for a "new mail" sound on OS/2, but others are supported, if I believe the entries I see in my WPS Sound object.

Comment 1

[Peter Weilbacher]

Attachment: mp3 detection fix

Comment 2

[Peter Weilbacher]

Attachment: Link to MMPM at compile time

OK, this is what I thought one should do. But if MMOS2 is completely messed up and one has to reboot to fix that this means that one could also not load the browser at all any more (until after the restart). So I now think this is not what should be done...

Comment 3

[Peter Weilbacher]

Rich, only now do I see that in your latest sydneyaudio patch you also load MDM dynamically at runtime. You never unload it, though. Is that because it behaves badly after unloads?
Then I think we should just remove the unload of it from nsSound.

Comment 4

[Rich Walsh]

I didn't think there was much reason to load MDM dynamically but I thought it best to conform to the prevailing opinion.  However, I couldn't see *any* reason for unloading it, so sydneyaudio doesn't - and nsSound shouldn't either (loading & unloading a dll every time a menu pops up? - crazy!).

I'd like to ..ummm.. reorganize nsSound sometime soon.

Comment 5

[Peter Weilbacher]

When I implemented it, it loaded the DLLs once for the whole session. The last instance of nsSound only got freed during program shutdown. That changed some months ago for reasons I haven't investigated yet.

But as I found out yesterday (twice) is that compile-time linking to MDM is a very bad idea for a program for which the primary purpose is something else that making noise through MMOS2.

Comment 7

[Peter Weilbacher]

Attachment: just don't free MDM

This seems to work better. Will try it out a few more days.

Comment 8

[Peter Weilbacher]

Attachment: don't free MDM

Comment 9

[Peter Weilbacher]

Attachment: add some more system sounds

This implements something similar to what the other platforms are using for their system sounds.

Tests that can be used to verify that this works are listed in bug 463209 comment 11.

Comment 10

[Peter Weilbacher]

Comment on attachment 388130 [details] [diff] [review]
mp3 detection fix

I have gone through my whole collection of multimedia files. Only one file was identified as MP3 by this new routine which the old one didn't also detect. And it turns out to be a FLI movie without sound.

So I think we better leave the old detection in place.

Comment 11

[Rich Walsh]

Comment on attachment 391675 [details] [diff] [review]
don't free MDM

If you're in a hurry to get something in before the next branch, then this will do for now.  Otherwise, don't do anything.  This file doesn't need to be patched, it needs to be reamed.

Comment 12

[Peter Weilbacher]

http://hg.mozilla.org/mozilla-central/rev/3ae688630837
http://hg.mozilla.org/mozilla-central/rev/938c11a621b0

I'm not sure what "reamed" means but if you think the whole MMOS2-DLL related stuff stinks then I fully agree. But I haven't found a better way yet. If you have, please open a new bug where we can follow up on this.

Comment 13

[Peter Weilbacher]

I pushed the MDM workaround to 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6ceb27dad7fa

The system sound patch needs to be altered a bit for 1.9.1, so I'm not going to mark this .3-fixed yet.


Hansi73, osw: I forgot to mention this earlier, but the Uniaud problems should be gone with the Firefox 3.5.x nightly from
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/contrib/2009/08/2009-08-01-06-mozilla-1.9.1/
Please let me know, if this is not the case for you.

Comment 14

[Hansi73]

Hello Peter,
yes the sound crash is gone. Thank you for your good work!!

Comment 15

[osw]

Hi Peter!
Sound bug is gone, at least in 1.9.1.3 build you have pointed us to. Well done. I'm waiting for patching 1.9.2 builds now, to start using ff 3.6. 
That bug was really painful and kept me away from using newer builds.
Thanks againg for good work on mozilla for warp.