503847 - Quick search does not remember selection on restart

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Ludovic Hirlimann [:Usul]]

STR:
In quick search select "subject or from".
Restart TB

Quick search should be on "subject or from" but is on subject

Comment 2

[Rimas Kudelis [use needinfo to ping]]

Isn't it a regression?

Comment 3

[David :Bienvenu]

I think this is a really bad regression, in that it appears that quick search is broken, when I search for a particular sender, or that I've lost mail -  i.e., I'm so used to quick search terms being sticky that I don't notice restart has reset the terms.

I'd really like this fixed for b3.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

This definitely blocks Tb3, and it should probably block 3.0b3 as well.

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Bumping to major based on it being a "really bad regression".

Comment 6

[Phil Ringnalda (:philor)]

With -r f6e6df3e2f7d (the changeset before bug 474701), it correctly persisted four of the six choices, coming back from "To or CC" as "From" and from "Subject, To or CC" as "Subject or From" (which I don't even see filed, making me question whether this is really an end-of-the-world regression).

Comment 7

[Mark Banner (:standard8)]

(In reply to comment #6)
> (which I don't even see filed, making
> me question whether this is really an end-of-the-world regression).

I think the significant issue is switching from "Subject or From" to "Subject" - it looses context unexpectedly and I'm guessing it is potentially the default for most people.

Comment 8

[Rimas Kudelis [use needinfo to ping]]

(In reply to comment #6)
> With -r f6e6df3e2f7d (the changeset before bug 474701), it correctly persisted
> four of the six choices, coming back from "To or CC" as "From" and from
> "Subject, To or CC" as "Subject or From" (which I don't even see filed, making
> me question whether this is really an end-of-the-world regression).

Didn't it depend on context ("To or CC" for Sent mail vs. "From" for Inbox)?

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

(In reply to comment #6)
> With -r f6e6df3e2f7d (the changeset before bug 474701), it correctly persisted
> four of the six choices, coming back from "To or CC" as "From" and from
> "Subject, To or CC" as "Subject or From" (which I don't even see filed, making
> me question whether this is really an end-of-the-world regression).

Rimas is right (comment #8).  onSearchFolderTypeChanged is doing the mapping on purpose and has always done the mapping on purpose.

http://mxr.mozilla.org/comm-central/source/mail/base/content/searchBar.js#262

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

Attachment: v1 clean up the search widget constructor, make regression go away?

This simplifies the constructor logic in the quick-search XBL widget.  Said widget and its exo-logic in searchBar.js still have non-trivial issues.

This improves things in my manual testing, but does not introduce a unit test.  A real unit test would uncover all the other horrible issues that we don't have time to fix in the next day.

Comment 11

[Phil Ringnalda (:philor)]

Comment on attachment 388385 [details] [diff] [review]
v1 clean up the search widget constructor, make regression go away?

Discretion being the better part of hotdog factory tours, I didn't look too closely beyond "yep, that does work," but working is a good thing. A rather unorthodox time and place to change the default item, but after all it *is* a better choice.

Comment 12

[Phil Ringnalda (:philor)]

Where by "change the default item" I apparently meant "and thanks for catching that the XUL wants 'value="2"' but would be defeated by a persistence problem."

Comment 14

[Andrew Sutherland [:asuth] (he/him)]

pushed: http://hg.mozilla.org/comm-central/rev/916b3ed62ca7