Closed Bug 50388 Opened 24 years ago Closed 24 years ago

"downloading" [helper app] dialog missing titlebar

Categories

(SeaMonkey :: UI Design, defect, P2)

Product:
SeaMonkey
Component:
UI Design
Platform:
PowerPC
All
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Future

People

(Reporter: bugzilla, Assigned: sfraser_bugs)

References

(
URL
)

Details

(Keywords: platform-parity, polish, regression, Whiteboard: [p:2]) 

this is a result of sfraser's fix to bug 41741.

to repro:
1. go to above url
2. in the nightly build section click one of the links to start downloading, eg,
Macintosh.
3. the Downloading dialog appears.

result: there's no titlebar on the dialog

expected: the dialog should have a titlebar; the title should say "Downloading"
mac only.
Keywords: nsbeta3, polish, pp, regression
Nav triage team: [nsbeta3-]; similar to 50389
Whiteboard: [nsbeta3-]
if there's no titlebar, the user (1) won't be able to move the dialog, (2) might
be *really* confused, ie, "what's this dialog for?"

simon, didn't you say that a fix for this would be easy?
Whiteboard: [nsbeta3-]
nav triage team: reassigning these 'dialogs missing title bar' bugs to sfraser. 
Original owners for these bugs need to provide sfraser with the name of the 
Javascript file(and maybe line#) where the call to open the dialog is made, 
please.
Assignee: law → sfraser
Added "titlebar" to chrome flags. Fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
vrfy fixed 2000.09.18.08 on mac.
Status: RESOLVED → VERIFIED
damn, i was looking at the wrong dialog. sorry! this is not/no longer fixed.
simon, feel free to pass over to themes or whatever appropriate engr to fix
this. thx!
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
cc pchen so he can tell me who brings up this titlebar-less dialog.

I thought Bill Law was responsible for the download progress dialog.
actually, this the the "smart downloading" dialog (clarified summary), not the
download progress dialog. this "smart" one asks if you want to open the file
using either a helper app, or to save it to disk.
Summary: Downloading dialog missing titlebar → "smart downloading" dialog missing titlebar
Simon, if you know what's causing this, that would be great! We've got a set of
bugs we've been trying to find a fix for like crazy! They are all the same:
dialogs missing titlebar.

In addition to this one, we've got bugs for:
1) the password dialog in common Dialogs
2) the mail 3-pane window

If there's a common solution let us know. It appears that
nsGlobalWindowImpl::SetTitle is getting called with the desired window title.
It's getting dropped on the floor some time after that.

mscott: different problem. This is dialogs missing their *titlebar* entirely, not 
failing to show the title. The fix for this bug is to find the openDialog call, 
and add "titlebar" to the chrome flags.

Failure to set the title is a bug that vidur has (and I can't find right now)

ahh thanks Simon. In that case, the titlebar chrome flag needs added to the JS
call in
nsUnknownContentTypeHandler::Show()

right now it just says "chrome".


titlebar needs to be there, nsbeta3+
Severity: normal → major
Priority: P3 → P2
Whiteboard: [nsbeta3+][p:2]
This does not meet any of the p1, p2, or p3 criteria.  pdtp5.
Priority: P2 → P5
Whiteboard: [nsbeta3+][p:2] → [nsbeta3+][p:2][pdtp5]
Target Milestone: --- → Future
pdt deems this not necessary for beta3, setting it to p5 which places it below
the wire for beta and rtm, marking future and adding helpwanted. If this impacts
your work or impacts another bug, please state your arguement in the bug, delete
entries in the whiteboard for reconsideration.
Keywords: helpwanted
Whiteboard: [nsbeta3+][p:2][pdtp5] → [nsbeta3-][p:2][pdtp5]
*** Bug 53742 has been marked as a duplicate of this bug. ***
*** Bug 54011 has been marked as a duplicate of this bug. ***
remove helpwanted keyword; Simon has a fix in hand for this bug.  Simon--please
attach a diff.

Note to pdt:  without the titlebar on the window, this doesn't even look like a
dialog.  Initially I didn't even realize the window had popped up because it
blended with the navigator window.
Keywords: helpwanted → rtm
Whiteboard: [nsbeta3-][p:2][pdtp5]
will consider when patch is attached and properly reviewed
Whiteboard: [rtm need patch attached]
Whiteboard: [rtm need patch attached] → [nsbeta3-][rtm need patch attached]
i believe this and bug 53742 are the same or similar issue
Priority: P5 → P2
Whiteboard: [nsbeta3-][rtm need patch attached] → [nsbeta3-][p:2][rtm+ NEED INFO]
Target Milestone: Future → M19
Marking rtm- as PDT does not yet understand why this is so critical.  Cc'ing
sgehani, the ownwer of the Mac installer.
Whiteboard: [nsbeta3-][p:2][rtm+ NEED INFO] → [nsbeta3-][p:2][rtm-]
I believe PDT was mislead by the title which read "smart downloading" while in
fact it appears that this bug is not related to SmartDownload technology
provided by the third party: Netzip.  This appears to have to do with regular
downloading from teh product on ce it is installed.

If my alteration of the summary string was incorrect please reinstate the
original and provide an explanation of what is meant by "smart downloading."
Thanks.
Summary: "smart downloading" dialog missing titlebar → "downloading" dialog missing titlebar
where is this dialog used in the commercial app? or is this used only in mozilla
build?
Target Milestone: M19 → Future
clarifying the summary a bit. and this appears in both commercial and mozilla
bits.
Summary: "downloading" dialog missing titlebar → "downloading" [helper app] dialog missing titlebar
This dialog shows up when downloading files, and prompts you to save the file to 
disk, or open with a specific application. It being modal prevents the user from 
putting the app into the background to search their hard disk for the correct 
application to open.

ok, I just sat with Sarah and she showed me one very visible location -- this
only happens on mac, but follow these steps:
1. go to http://home.netscape.com
2. select the 'download' buttom
3. when the download page is displayed (which is where customers will download
netscape 6), select 'Download It Now'
4. when the Downloading dialog is displayed (a modal) -- move it to the upper
left corner of your screen. you can't, well ok just close the dialog (not
cancel), you can't

that probably isn't what users would expect
Whiteboard: [nsbeta3-][p:2][rtm-] → [nsbeta3-][p:2]
ok, [rtm need info]. Is the progress dialog supposed to be modal?
Whiteboard: [nsbeta3-][p:2] → [nsbeta3-][p:2][rtm need info]
this was actually fixed as part of 44176 which i just checked in tonight into
the tip and the branch. marking fixed.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
vrfy fixed on Mac OS 9.0 using opt comm branch bits, 2000.10.09.10-n6.

needs trunk vrf'tion.
Keywords: nsbeta3 → vtrunk
Whiteboard: [nsbeta3-][p:2][rtm need info] → [p:2]
Verified Fixed on trunk build
mac 101704 Mac OS9
Setting bug to Verified and removing vtrunk keyword
Status: RESOLVED → VERIFIED
Keywords: vtrunk
OS: All
Product: Core → Mozilla Application Suite
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.