503885 - Order of preview screenshots reverses after 9th preview

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Mark Cramer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.11) Gecko/2009060215 Firefox/3.0.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.11) Gecko/2009060215 Firefox/3.0.11

I have 9 preview screenshots that I've uploaded to https://addons.mozilla.org/en-US/firefox/addon/6549. In order to get them to appear in the proper order, I uploaded one at a time and then waited for each one to fully "entered" into the system before uploading the next.

This worked great for the first 8. The organization of the screenshots was like this:

#1 #2 #3
#4 #5 #6
#7 #8

As soon as I uploaded the 9th, however, the order reversed, looking like this:

#8 #7 #6
#5 #4 #3
#2 #1 #9

Upon removing the 9th preview the order went back to the way it's supposed to be. When I added it back a 2nd time the order reversed again. I've since removed the 9th image and am sticking with 8 for the time being.

Reproducible: Always

Steps to Reproduce:
1. Upload 8 preview images, waiting a "significant" amount of time between each.
2. Verify that the 8 images are in the proper order.
3. Upload the 9th image.



I suppose that if I wanted to try to workaround this issue I could upload the images reverse order (#8, #7, #6... and finally #9) so that when I added the 9th they'd switch back to how I want them. Perhaps I'll give that a try later.

Comment 1

[fcp]

I reproduced the behavior on preview.addons.mozilla.org.
https://preview.addons.mozilla.org/en-US/firefox/addon/12312/
I changed and added previews on my add-on on preview.a.m.o so that on the developer panel, the ten previews from “0” to “9” including the default preview “0” are shown in the increasing order.  On the add-on details page, the nine non-default previews are shown in a wrong order as stated in the original report.

If anyone else tries to reproduce, note that the precise order in which the non-default previews are listed in the add-on details page changes slightly depending on which image you choose as the default preview (but anyway the order is wrong).

This is not a bug in the Admin/Editor Tools.  I mark this as a Public Pages bug because I guess that the cause of this bug lies in generation of the add-on details page, but the cause might be in the developer tools.

Comment 2

[RJ Walsh [:rjwalsh]]

Attachment: Fix

Changing the sort order to fall back on ID

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 395154 [details] [diff] [review]
Fix

should work, thanks

Comment 4

[RJ Walsh [:rjwalsh]]

Fixed in r49522

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Seems fixed to me, using fcp's testcase; fcp -- mine verifying on preview?  Thanks!

Comment 6

[fcp]

Verified fixed with several different choices for default preview images on preview.addons.mozilla.org.  Thanks Mark for reporting, RJ for fixing, Wil and Stephen for verifying!

Comment 7

[Mark Cramer]

Thank you, guys, for looking into this! I don't think this is a big deal, however, now when I upload #9 I get this:

#1 #8 #7
#6 #5 #4
#3 #2 #9

So now #1 and #9 and good, but everything else is reversed, although #5 happens to fall in the right place, too. When I then remove #9 it goes back to this:

#1 #2 #3
#4 #5 #6
#7 #8

I'm totally fine with this being low priority, but I think it's still broken. Please let me know if you'd like for me to do anything to help.

Comment 8

[fcp]

Mark, if you tried it on preview.addons.mozilla.org and still reproduced the bug, please reopen this bug.

Currently the bug has been fixed only on preview.addons.mozilla.org.  The fix will be pushed to addons.mozilla.org when addons.mozilla.org is updated to AMO 5.0.9.  The update to AMO 5.0.9 is tentatively scheduled on August 27 (see https://wiki.mozilla.org/AMO:Meeting_Notes ).

Comment 9

[Mark Cramer]

Apologies for reopening the bug. I didn't realize the fix wasn't pushed live. I've now tested on preview.addons.mozilla.org and it's working great! I'll check again when AMO 5.0.9 goes live, but nicely done!

Comment 10

[Mark Cramer]

Verified fixed with AMO 5.0.9. Great job!