back out (put back) DOM object access

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: vlad, Assigned: vlad)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nv])

Attachments

(1 attachment)

Created attachment 388247 [details] [diff] [review]
put back NPNVDOMElement and NPNVDOMWindow

NPNVDOMElement and NPNVDOMWindow are used by the ActiveX plugin shim; we need for that shim to keep working, at least for the next release.  This code puts back support for those to nsNPAPIPlugin.cpp.
Attachment #388247 - Flags: review?(jst)

Comment 1

9 years ago
Wow, why do you need the activex shim? And why does the activex shim need NPNVDomElement and such?
(In reply to comment #1)
> Wow, why do you need the activex shim?

We need it to get to Flash on Windows CE/Mobile, until they ship Flash 10 which will (hopefully) be NPAPI.

> And why does the activex shim need NPNVDomElement and such?

That I don't exactly know; it needed DOMDocument to grab the JSContext to do some JS-ery, and I didn't look into why it needed DOMElement.

Updated

9 years ago
OS: Windows XP → Windows CE
Hardware: x86 → All
Comment on attachment 388247 [details] [diff] [review]
put back NPNVDOMElement and NPNVDOMWindow

I'm fine with putting this back to keep the current WinCE flash going, but I'd prefer to see us enable this *only* for WinCE so plugins on other platforms don't think these will remain in our tree. So r+sr=jst with the appropriate #ifdef and a comment explaining why this code exists only for WinCE.
Attachment #388247 - Flags: superreview+
Attachment #388247 - Flags: review?(jst)
Attachment #388247 - Flags: review+
Assignee: nobody → vladimir
http://hg.mozilla.org/mozilla-central/rev/eb39efc134fb
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.