Created attachment 388288 [details] fix null data NULL is generally really really bad and we should be defaulting to an empty string. (Case in point, it caused bug 485329) Attaching two SQL queries, one to update the existing articles to '' and one to add a default value to the data column so this doesn't happen again.
Created attachment 388301 [details] fix tiki_history We should fix tiki_history too in case we come to rely on the non-NULL nature of page info.
Assignee: nobody → cwwmozilla
Status: NEW → ASSIGNED
Attachment #388301 - Flags: review?(laura)
Are there places in the code that depend on it being NULL (ie tests of ISNULL and so on)? I'm a little scared to r+ this without an audit.
Comment on attachment 388288 [details] fix null data See my previous comment.
Attachment #388288 - Flags: review-
Comment on attachment 388301 [details] fix tiki_history See my previous comment.
Attachment #388301 - Flags: review?(laura) → review-
Note as well that NULL is semantically different from the empty string. I'm not convinced. r- for now.
Bugs in tikiwiki, going away.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.