503935 - Don't allow NULL values in data column in tiki_pages

Status: RESOLVED INVALID

(support.mozilla.org :: Knowledge Base Software, task)

Description

[[:Cww]]

Attachment: fix null data

NULL is generally really really bad and we should be defaulting to an empty string.  (Case in point, it caused bug 485329) Attaching two SQL queries, one to update the existing articles to '' and one to add a default value to the data column so this doesn't happen again.

Comment 1

[[:Cww]]

Attachment: fix tiki_history

We should fix tiki_history too in case we come to rely on the non-NULL nature of page info.

Comment 2

[Laura Thomson :laura]

Are there places in the code that depend on it being NULL (ie tests of ISNULL and so on)?  I'm a little scared to r+ this without an audit.

Comment 3

[Laura Thomson :laura]

Comment on attachment 388288 [details]
fix null data

See my previous comment.

Comment 4

[Laura Thomson :laura]

Comment on attachment 388301 [details]
fix tiki_history

See my previous comment.

Comment 5

[Laura Thomson :laura]

Note as well that NULL is semantically different from the empty string.  I'm
not convinced. r- for now.

Comment 6

[James Socol [:jsocol, :james]]

Bugs in tikiwiki, going away.