Creating a bookmark by dragging to the sidebar detaches the tab

RESOLVED FIXED

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Sylvain Pasche, Assigned: Neil Deakin)

Tracking

({regression})

Trunk
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
This is a regression from bug 455590.

Steps to reproduce:
 - open a window with at least two tabs.
 - drag one of the tab to the bookmarks sidebar to create a new bookmark.
Actual result:
 The tab being bookmarked is detached to a new window.
Expected result:
 The bookmarked tab remains in the current window.
(Assignee)

Comment 1

9 years ago
Created attachment 388737 [details] [diff] [review]
pass the dataTransfer to the treeview methods
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #388737 - Flags: review?(mak77)
Comment on attachment 388737 [details] [diff] [review]
pass the dataTransfer to the treeview methods

mak is gone for a while, but I can review this.

r=sdwilsh
Attachment #388737 - Flags: review?(mak77) → review+
(Assignee)

Comment 3

9 years ago
http://hg.mozilla.org/mozilla-central/rev/8ac1c21c2a5e
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.