503968 - Download button missing for experimental add-ons in Meet the developer page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: download button missing

steps to reproduce:
Go to https://preview.addons.mozilla.org/en-US/firefox/addon/12466/developers

observed behavior:
-Download button is missing for experimental addons in "Meet the developer" page.
-For regular addons,download button is present.

Comment 1

[Wil Clouser [:clouserw]]

wfm, what browser/version/etc?

Comment 2

[krupa raj[:krupa]]

STR:
1.Do NOT log in
2.Navigate to the developer profile for an experimental add-on

reproducible in Ff3.5/IE7/IE8

Comment 3

[Wil Clouser [:clouserw]]

(In reply to comment #2)
> STR:
> 1.Do NOT log in
> 2.Navigate to the developer profile for an experimental add-on
> 
> reproducible in Ff3.5/IE7/IE8

Thanks, I can reproduce now

Comment 4

[Wil Clouser [:clouserw]]

This actually looks like an XSS/injection issue:

Error: missing ) after argument list
Source File: https://preview.addons.mozilla.org/en-US/firefox/addon/12466/developers
Line: 432, Column: 97
Source Code:
setTimeout(function() {initExpConfirm('70522-17791944');fixPlatformLinks('70522-17791944', 'tets'ನಿಂತ ಮೇಲೆ ಹಾಸ');},0);

Comment 5

[Jeff Balogh (:jbalogh)]

Yeah, an add-on with a good name looks fine: https://preview.addons.mozilla.org/en-US/firefox/addon/12377/developers

Comment 6

[Wil Clouser [:clouserw]]

Attachment: use publish()

Comment 7

[Jeff Balogh (:jbalogh)]

Comment on attachment 388395 [details] [diff] [review]
use publish()

Only a 1/2 r+, for the publish part.  Why are you moving pageTitle out of the view?  That doesn't feel like the domain of the controller.

Comment 8

[Wil Clouser [:clouserw]]

(In reply to comment #7)
> (From update of attachment 388395 [details] [diff] [review])
> Only a 1/2 r+, for the publish part.  Why are you moving pageTitle out of the
> view?  That doesn't feel like the domain of the controller.

because cake expects it to be set in the controller and escapes the title automatically

Comment 9

[Wil Clouser [:clouserw]]

r29730

Comment 10

[Jeff Balogh (:jbalogh)]

(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 388395 [details] [diff] [review] [details])
> > Only a 1/2 r+, for the publish part.  Why are you moving pageTitle out of the
> > view?  That doesn't feel like the domain of the controller.
> 
> because cake expects it to be set in the controller and escapes the title
> automatically

Oh of course, where else would the title of an html page belong? :(

Comment 11

[Wil Clouser [:clouserw]]

(In reply to comment #10)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > (From update of attachment 388395 [details] [diff] [review] [details] [details])
> > > Only a 1/2 r+, for the publish part.  Why are you moving pageTitle out of the
> > > view?  That doesn't feel like the domain of the controller.
> > 
> > because cake expects it to be set in the controller and escapes the title
> > automatically
> 
> Oh of course, where else would the title of an html page belong? :(

Actually, this one may be on us.  We're running it through $html->entities() in amo2009.thtml

Comment 12

[krupa raj[:krupa]]

Download button is now visible.The JS error is not occurring anymore.Marking this verified.