504012 - Missing includes on multiple files

Status: RESOLVED DUPLICATE of bug 488111

(Toolkit :: Crash Reporting, defect)

Description

[Jory A. Pratt [:anarchy]]

Attachment: patch to include proper stdio header.

There are multiple files that are missing '#include <stdio.h>', there are enviroments that will cause this to break the build. A great example was reported to gentoo, which shows all three files that make standard calls but fail to include the proper header. Patch will be attached.

Actual errors are ....

/var/tmp/portage/mail-client/mozilla-thunderbird-3.0_beta2-r1/work/mozilla/toolkit/crashreporter/google-breakpad/src/common/linux/
dump_symbols.cc
i686-pc-linux-gnu-g++ -o host_dump_symbols.o -c -march=native -pipe -Wno-return-type -w -I./../.. -I. -I.  -I../../../../../../dist/include   -I../../../../../../dist/include/breakpad_linux_common -I/usr/include/nspr     -I/var/tmp/portage/mail-client/mozilla-thunderbird-3.0_beta2-r1/work/mozilla/dist/sdk/include -I/usr/include/nspr dump_symbols.cc
dump_symbols.cc: In function ‘bool<unnamed>::WriteFormat(int, const char*, ...)’:
dump_symbols.cc:176: erreur: ‘vsnprintf’ was not declared in this scope
dump_symbols.cc: In function ‘bool<unnamed>::ComputeSizeAndRVA(Elf32_Addr, <unnamed>::SymbolInfo*)’:
dump_symbols.cc:487: erreur: ‘stderr’ was not declared in this scope
dump_symbols.cc:488: erreur: ‘fprintf’ was not declared in this scope
dump_symbols.cc: In function ‘bool<unnamed>::LoadSymbols(Elf32_Ehdr*, <unnamed>::SymbolInfo*)’:
dump_symbols.cc:586: erreur: ‘stderr’ was not declared in this scope
dump_symbols.cc:586: erreur: ‘fprintf’ was not declared in this scope


/var/tmp/portage/mail-client/mozilla-thunderbird-3.0_beta2-r1/work/mozilla/toolkit/crashreporter/google-breakpad/src/client/linux/handler   
exception_handler.cc
i686-pc-linux-gnu-g++ -o exception_handler.o -c -I../../../../../../../dist/include/system_wrappers -include ../../../../../../../config/gcc_hidden.h -DMOZ_THUNDERBIRD=1 -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -I./../../.. -I. -I.  -I../../../../../../../dist/include   -I../../../../../../../dist/include/handler -I/usr/include/nspr     -I/var/tmp/portage/mail-client/mozilla-thunderbird-3.0_beta2-r1/work/mozilla/dist/sdk/include    -fPIC   -fno-rtti -fno-handle-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -march=native -pipe -Wno-return-type -w -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions    -DMOZILLA_CLIENT -include ../../../../../../../mozilla-config.h -Wp,-MD,.deps/exception_handler.pp exception_handler.cc
exception_handler.cc: In destructor ‘google_breakpad::ExceptionHandler::~ExceptionHandler()’:
exception_handler.cc:100: erreur: ‘stderr’ was not declared in this scope
exception_handler.cc:100: erreur: ‘fprintf’ was not declared in this scope
exception_handler.cc: In member function ‘bool google_breakpad::ExceptionHandler::InternalWriteMinidump(int, uintptr_t, sigcontext**)’:
exception_handler.cc:241: erreur: ‘stderr’ was not declared in this scope
exception_handler.cc:242: erreur: ‘fprintf’ was not declared in this scope
exception_handler.cc: In member function ‘void google_breakpad::ExceptionHandler::UpdateNextID()’:
exception_handler.cc:269: erreur: ‘snprintf’ was not declared in this scope
gmake[6]: *** [exception_handler.o] Erreur 1


minidump_generator.cc
i686-pc-linux-gnu-g++ -o minidump_generator.o -c -I../../../../../../../dist/include/system_wrappers -include ../../../../../../../config/gcc_hidden.h -DMOZ_THUNDERBIRD=1 -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -I./../../.. -I. -I.  -I../../../../../../../dist/include   -I../../../../../../../dist/include/handler -I/usr/include/nspr     -I/var/tmp/portage/mail-client/mozilla-thunderbird-3.0_beta2-r1/work/mozilla/dist/sdk/include    -fPIC   -fno-rtti -fno-handle-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -march=native -pipe -Wno-return-type -w -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions    -DMOZILLA_CLIENT -include ../../../../../../../mozilla-config.h -Wp,-MD,.deps/minidump_generator.pp minidump_generator.cc
minidump_generator.cc: In function ‘bool<unnamed>::WriteThreadStream(google_breakpad::MinidumpFileWriter*, const google_breakpad::LinuxThread*, const google_breakpad::ThreadInfo&, MDRawThread*)’:
minidump_generator.cc:307: erreur: ‘perror’ was not declared in this scope
minidump_generator.cc: In function ‘bool<unnamed>::WriteCPUInformation(MDRawSystemInfo*)’:
minidump_generator.cc:355: erreur: ‘fopen’ was not declared in this scope
minidump_generator.cc:357: erreur: ‘fgets’ was not declared in this scope
minidump_generator.cc:364: erreur: ‘sscanf’ was not declared in this scope
minidump_generator.cc:389: erreur: ‘fclose’ was not declared in this scope