504065 - browser.js includes should be at the top

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

The includes are currently somewhere in the middle, which doesn't make sense. They used to be at the end, presumably, but somebody started appending more stuff after that. As we should encourage people to move stuff to separate files when it can be separated logically, I think it makes sense to move the includes to a more prominent place at the top.

This also moves browser-textZoom.js to browser-fullZoom.js.

Comment 1

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/4687aad1a699

Comment 2

[Steffen Wilberg]

Looks like the copy/rename info got lost, probably by using hg rebase with a buggy Mercurial version prior to 1.3.

Comment 3

[Ed Lee :Mardak]

You mean the rename to this?
http://hg.mozilla.org/mozilla-central/log/4687aad1a699/browser/base/content/browser-fullZoom.js

There's a link to "base" for the first revision and the annotation looks right. ?

Comment 4

[Steffen Wilberg]

Ah, ok, never mind then. I somehow expected a listing of the previous revisions and didn't notice that "base" link.