504160 - use proper Toolbar.png regions for the inactive window state

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Markus Stange [:mstange]]

Right now we're using the active images with 70% opacity, which is just wrong.

Also, the glyphs on the inactive toolbar buttons should look disabled at all times as long as the buttons aren't click-through (bug 392188).

Comment 1

[Markus Stange [:mstange]]

Toolbar.png has been updated in bug 494927.

Stephen, I think we also need an image for the *checked* bookmarks and history buttons in inactive mode.

Comment 2

[Markus Stange [:mstange]]

Well, maybe we don't need them. Using opacity: 0.7 on the active checked icons looks good, too.

Comment 3

[Markus Stange [:mstange]]

Attachment: fix v1

This patch applies on top of the one in bug 505699. If this gets reviewed first, which is not unlikely, I'll just leave out the parts with the fullscreen and restore buttons when checking this in, and check them in after bug 505699.

In this patch I'm also removing some !importants and replacing them with :not([disabled="true"]).

We have many buttons that don't ever get disabled but where we still set the disabled image region. This probably doesn't make sense but I didn't touch it.

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #1)
> Toolbar.png has been updated in bug 494927.

Not anymore. I've removed the inactive state in an attempt to avoid the txul issue. We can try to re-add the regions here, or maybe use the ones for the disabled state with a reduced opacity. Looking at attachment 394375 [details], I'm leaning towards the latter.

(In reply to comment #3)
> We have many buttons that don't ever get disabled but where we still set the
> disabled image region. This probably doesn't make sense but I didn't touch it.

Filed bug 510442.

Comment 5

[Markus Stange [:mstange]]

(In reply to comment #4)
> or maybe use the ones for the disabled state with a reduced opacity. Looking
> at attachment 394375 [details], I'm leaning towards the latter.

When I looked at the image I thought that it might work, too, but in reality it doesn't work at all. For example, with 0.75 opacity (what we're using right now), the border is still much too dark (#7F7F7F at the top and #797979 at the bottom, whereas they should be #A3A3A3 and #9B9B9B).

I'm still trying to figure out how to avoid the Txul hit. The only way to find out is probably to run Txul locally and experiment a little.

Comment 6

[Markus Stange [:mstange]]

You know what, we could fool Txul by splitting Toolbar.png into two images: one for the buttons that are in the default set, and one for the rest. This might not even be cheating.

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> This might not even be cheating.

I think it is, as we expect users to put these buttons on the toolbar.