In download progress dialog, indicate availability of context menus through WAI-ARIA attribute.

RESOLVED FIXED

Status

SeaMonkey
Download & File Handling
--
trivial
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: MarcoZ, Assigned: MarcoZ)

Tracking

({access})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

953 bytes, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
In the download progress dialog, indicate that the file name and server name labels have context menus that can be invoked. Use the aria-haspopup attribute with a value of "true" on these elements, as specified here:
http://www.w3.org/TR/wai-aria/#aria-haspopup
(Assignee)

Comment 1

8 years ago
Created attachment 388527 [details] [diff] [review]
Patch
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED
Attachment #388527 - Flags: superreview?(neil)
Attachment #388527 - Flags: review?(neil)

Comment 2

8 years ago
So accessibility ignores the context and popup attributes?

Comment 3

8 years ago
(In reply to comment #2)
> So accessibility ignores the context and popup attributes?

Good point. Afaik we don't expose any relations between context menu and element to AT and AT users invokes keyboard shortcuts like sighted users do. But iirc we have a bug to expose context menu as well. Concerning popup menus, yes, I think we should take into account @popup attribute and expose STATE_HAS_POPUP on related element.
(Assignee)

Comment 4

8 years ago
(In reply to comment #3)
> yes, I think we should take into account @popup attribute and expose
> STATE_HAS_POPUP on related element.

I filed bug 504252 for this to deal with it in trunk. However since we don't know whether this will make its way into 1.9.1 eventually, I suggest taking this as a workaround, and reverting it as soon as SeaMonkey regularly builds against trunk and we have bug 504252 fixed.

Comment 5

8 years ago
(In reply to comment #4)

>I suggest taking
> this as a workaround, and reverting it as soon as SeaMonkey regularly builds
> against trunk and we have bug 504252 fixed.

I don't mind though it's worth to add XXX comment to refer new bug.

Comment 6

8 years ago
Comment on attachment 388527 [details] [diff] [review]
Patch

I don't need an XXX comment here if you note the link between the bugs here so that you remember to undo this at some point after fixing the other bug ;-)
Attachment #388527 - Flags: superreview?(neil)
Attachment #388527 - Flags: superreview+
Attachment #388527 - Flags: review?(neil)
Attachment #388527 - Flags: review+

Comment 7

8 years ago
That is, if you note (presumably in bug 504252) to revert this change.
(Assignee)

Updated

8 years ago
Attachment #388527 - Flags: approval-seamonkey2.0b1?
(Assignee)

Comment 8

8 years ago
Comment on attachment 388527 [details] [diff] [review]
Patch

Cancelling approval since it's past code freeze for B1. Waiting for tree to reopen.
Attachment #388527 - Flags: approval-seamonkey2.0b1?
(Assignee)

Comment 9

8 years ago
Pushed: http://hg.mozilla.org/comm-central/rev/e800384a1890
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.