nsAStreamCopier::Process can use sourceCondition, sinkCondition uninitialized if someone cancels the copy early
RESOLVED
FIXED
Status
()
People
(Reporter: timeless, Assigned: timeless)
Tracking
({coverity})
Firefox Tracking Flags
(Not tracked)
Details
(URL)
Attachments
(1 attachment, 1 obsolete attachment)
|
1.25 KB,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
Coverity is complaining that this code temporarily uses sourceCondition, sinkCondition uninitialized. It's true, but the usage is local, and an optimizer could probably reach the same conclusion as my patch and do it automatically, but i'd rather not rely on that optimizer.
Created attachment 388544 [details] [diff] [review] fix warning
Attachment #388544 -
Flags: review?(doug.turner)
|
||
Updated•9 years ago
|
||
Attachment #388544 -
Flags: review?(doug.turner) → review?(jduell.mcbugs)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 388544 [details] [diff] [review] fix warning This looks fine to me. It's a really small change--do we even need sr?
Attachment #388544 -
Flags: review?(jduell.mcbugs) → review+
|
||
Comment 3•9 years ago
|
||
No SR needed.
Created attachment 393756 [details] [diff] [review] fix reviewer
Attachment #388544 -
Attachment is obsolete: true
Attachment #393756 -
Flags: review+
http://hg.mozilla.org/mozilla-central/rev/df76fbd4b076
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•