Closed Bug 504170 Opened 11 years ago Closed 11 years ago

nsAStreamCopier::Process can use sourceCondition, sinkCondition uninitialized if someone cancels the copy early

Categories

(Core :: XPCOM, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file, 1 obsolete file)

1.25 KB, patch
timeless
: review+
Details | Diff | Splinter Review
Coverity is complaining that this code temporarily uses sourceCondition, sinkCondition uninitialized.

It's true, but the usage is local, and an optimizer could probably reach the same conclusion as my patch and do it automatically, but i'd rather not rely on that optimizer.
Attached patch fix warning (obsolete) — Splinter Review
Attachment #388544 - Flags: review?(doug.turner)
Attachment #388544 - Flags: review?(doug.turner) → review?(jduell.mcbugs)
Comment on attachment 388544 [details] [diff] [review]
fix warning

This looks fine to me.   It's a really small change--do we even need sr?
Attachment #388544 - Flags: review?(jduell.mcbugs) → review+
Attached patch fix reviewerSplinter Review
Attachment #388544 - Attachment is obsolete: true
Attachment #393756 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/df76fbd4b076
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.