504233 - Add SIZE_MAX, etc. #defines to jsinttypes.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jeff Walden [:Waldo]]

For greater styling as though we were using C99's definitions directly...

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

It's not strictly to spec as the comments in the changes note, but it's enough for us.  No rush on review, just general incremental code hygiene improvement...

Comment 2

[Jim Blandy :jimb]

Comment on attachment 388816 [details] [diff] [review]
Patch

Could we have static asserts for the ptrdiff limits, too?

I think jsnum.cpp is as good a place as any for the static asserts.

Comment 3

[Jim Blandy :jimb]

Comment on attachment 388816 [details] [diff] [review]
Patch

This looks great --- but I would like to have static asserts for the pointer-sized types, and I'd like to have all the limit definitions protected as they are in <stdint.h>, to give "jsstdint.h" as similar an interface to the standard as possible.

Comment 4

[Jeff Walden [:Waldo]]

Attachment: v2

On my system stdlib.h includes stdint.h, so the define has to be way way early.  Given that, I gave up on just putting a universal define in jsprvtd.h; we'll have to suck it up and add it to files as needed.

Comment 5

[Brendan Eich [:brendan]]

We used to have a "jsstddef.h" include that by design had to come first (for some Windows 3.1 brain damage, I will drink if I have to remember it all -- had to do with ptrdiff_t being int16 and incapable of expressing distance between array elements on Win16!). Maybe we should bring it back.

"jstypes.h" is first among the local includes but after standard header file includes alas.

Just thinking about how you could get this macro "for free".

/be

Comment 6

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/tracemonkey/rev/3b61bf6ab635
http://hg.mozilla.org/tracemonkey/rev/a230a19f988b

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/3b61bf6ab635

Comment 8

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c409ff4fe37f