504236 - Allow separate weave and storage versions

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Ed Lee :Mardak]

We set both versions to whatever the weave version is. This can cause unnecessary server wipes on updates that don't actually change record formats.

Comment 1

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/fb1fa1f09a67
Update the substitution names to separately replace the storage version with the new storage version Makefile variable.

Comment 2

[Ed Lee :Mardak]

thunder: Should we bump storage_version to 0.5pre2 because bug 479189 introduces a new record type.. BookmarkQuery for place: queries. Right now they get synced as Bookmark, so a wipe is needed to make sure they get uploaded with the right type.

But then again how many people have smart tags folders?

Comment 3

[Dan Mills [:thunder]]

(In reply to comment #2)
> thunder: Should we bump storage_version to 0.5pre2 because bug 479189
> introduces a new record type.. BookmarkQuery for place: queries. Right now they
> get synced as Bookmark, so a wipe is needed to make sure they get uploaded with
> the right type.
> 
> But then again how many people have smart tags folders?

The local metadata wipe should take care of fixing the broken records.  So long as we can read the 0.5pre1 server format, we should not bump the min storage version.