Closed
Bug 504239
Opened 15 years ago
Closed 15 years ago
Remove a useless chunk of a likely-unused script for a barely-supported configuration
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: philor)
Details
Attachments
(1 file)
687 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Back in the day of srcdir builds, clean-config.sh was probably pretty handy: no need to even have a mozconfig findable, just fire it off from $topsrcdir and it would remove all makefiles (that were produced by all-makefiles, anyway) and configure output. Now, with srcdir support amounting to "we won't automatically wontfix a bug just because it only happens with srcdir builds" it probably doesn't see much, if any, use, but it's still pointless to have it looking for a file which hasn't existed since bug 381902 landed two years ago as a sign that it needs to remove mailnews makefiles when mailnews doesn't exist in mozilla-central. (And yes, I'm afraid it would amuse me if the timing works out so this is the 500th bug I've fixed. Triviality a speciality.)
Attachment #388618 -
Flags: review?(ted.mielczarek)
Comment 1•15 years ago
|
||
Comment on attachment 388618 [details] [diff] [review] rm You know, if you removed this whole script and the cleansrcdir target, I bet nobody would notice.
Attachment #388618 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Updated•15 years ago
|
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/6ec3da250158
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•