Request removal of #include <rpc/types.h> from prinet.h

Status

NSPR
NSPR
--
enhancement
8 years ago
5 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Nelson Bolyard (seldom reads bugmail))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

NSPR's internal header file pr/include/md/_freebsd.h includes these lines,
which go all the way back to rev 1.1:

  /* freebsd has INADDR_LOOPBACK defined, but in /usr/include/rpc/types.h, 
     and I didn't want to be including that.. */
  #ifndef INADDR_LOOPBACK
  #define INADDR_LOOPBACK         (u_long)0x7F000001
  #endif

But NSPR's public header file prinet.h contains these lines:

  #if defined(FREEBSD) || defined(BSDI) || defined(QNX)
  #include <rpc/types.h> /* the only place that defines INADDR_LOOPBACK */
  #endif

This inconsistency is odd.  NSPR makes its users include a file that it 
does not always include itself.  

Sun's NSPR/NSS team has received a request to change prinet.h to use the 
same #define technique as used in _freebsd.h, rather than continuing to 
#include <rpc/types.h> to resolve some issues with the file rpc/types.h 
in recent versions of FreeBSD.

Here, I want to ask the NSPR developers: Is this a reasonable request?
Wan-Teh, what's your opinion?

Comment 1

8 years ago
This is fine.
(Assignee)

Updated

8 years ago
Assignee: wtc → nelson

Comment 2

5 years ago
Is this still actual?
You need to log in before you can comment on or make changes to this bug.