504300 - Preferences window styles should live in toolkit, not browser

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Markus Stange [:mstange]]

Attachment: fix v1

Comment 1

[Markus Stange [:mstange]]

Attachment: before (DownloadHelper extension preferences)

Comment 2

[Markus Stange [:mstange]]

Attachment: after

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 388676 [details] [diff] [review]
fix v1

> prefwindow {
>   padding: 0;
>+  font: -moz-dialog !important;

Can you explain why the !important is needed?

>+:root:not([active])

You can use prefwindow here.

Comment 4

[[e-mail]]

Comment on attachment 388676 [details] [diff] [review]
fix v1

>-  skin/classic/browser/preferences/panebutton-active.png    (preferences/panebutton-active.png)
>-  skin/classic/browser/preferences/panebutton-inactive.png  (preferences/panebutton-inactive.png)
...
>++  skin/classic/global/icons/panebutton-active.png                    (icons/panebutton-active.png)
>++  skin/classic/global/icons/panebutton-inactive.png                  (icons/panebutton-inactive.png)
Why aren't your hg moves in the git diff? ;-)
[Side note: why are these all + (force copy) anyway?]

Comment 5

[Markus Stange [:mstange]]

(In reply to comment #3)
> (From update of attachment 388676 [details] [diff] [review])
> > prefwindow {
> >   padding: 0;
> >+  font: -moz-dialog !important;
> 
> Can you explain why the !important is needed?

Because otherwise global.css takes precedence with its font: message-box. I plan to change that in bug 501970.

> 
> >+:root:not([active])
> 
> You can use prefwindow here.

OK.

(In reply to comment #4)
> Why aren't your hg moves in the git diff? ;-)

They are:

>diff --git a/browser/themes/pinstripe/browser/preferences/panebutton-active.png b/toolkit/themes/pinstripe/global/icons/panebutton-active.png
>rename from browser/themes/pinstripe/browser/preferences/panebutton-active.png
>rename to toolkit/themes/pinstripe/global/icons/panebutton-active.png
>diff --git a/browser/themes/pinstripe/browser/preferences/panebutton-inactive.png b/toolkit/themes/pinstripe/global/icons/panebutton-inactive.png
>rename from browser/themes/pinstripe/browser/preferences/panebutton-inactive.png
>rename to toolkit/themes/pinstripe/global/icons/panebutton-inactive.png

Comment 6

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/d05508ec2ab3

Comment 7

[[e-mail]]

(In reply to comment #5)
> (In reply to comment #4)
> > Why aren't your hg moves in the git diff? ;-)
> They are
D'oh, I forgot hg lists them in order of target location...