Closed Bug 504300 Opened 11 years ago Closed 11 years ago

Preferences window styles should live in toolkit, not browser

Categories

(Toolkit :: Themes, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(3 files)

Attached patch fix v1Splinter Review
No description provided.
Attachment #388676 - Flags: review?(dao)
Attached image after
Blocks: 483537
Comment on attachment 388676 [details] [diff] [review]
fix v1

> prefwindow {
>   padding: 0;
>+  font: -moz-dialog !important;

Can you explain why the !important is needed?

>+:root:not([active])

You can use prefwindow here.
Attachment #388676 - Flags: review?(dao) → review+
Comment on attachment 388676 [details] [diff] [review]
fix v1

>-  skin/classic/browser/preferences/panebutton-active.png    (preferences/panebutton-active.png)
>-  skin/classic/browser/preferences/panebutton-inactive.png  (preferences/panebutton-inactive.png)
...
>++  skin/classic/global/icons/panebutton-active.png                    (icons/panebutton-active.png)
>++  skin/classic/global/icons/panebutton-inactive.png                  (icons/panebutton-inactive.png)
Why aren't your hg moves in the git diff? ;-)
[Side note: why are these all + (force copy) anyway?]
(In reply to comment #3)
> (From update of attachment 388676 [details] [diff] [review])
> > prefwindow {
> >   padding: 0;
> >+  font: -moz-dialog !important;
> 
> Can you explain why the !important is needed?

Because otherwise global.css takes precedence with its font: message-box. I plan to change that in bug 501970.

> 
> >+:root:not([active])
> 
> You can use prefwindow here.

OK.

(In reply to comment #4)
> Why aren't your hg moves in the git diff? ;-)

They are:

>diff --git a/browser/themes/pinstripe/browser/preferences/panebutton-active.png b/toolkit/themes/pinstripe/global/icons/panebutton-active.png
>rename from browser/themes/pinstripe/browser/preferences/panebutton-active.png
>rename to toolkit/themes/pinstripe/global/icons/panebutton-active.png
>diff --git a/browser/themes/pinstripe/browser/preferences/panebutton-inactive.png b/toolkit/themes/pinstripe/global/icons/panebutton-inactive.png
>rename from browser/themes/pinstripe/browser/preferences/panebutton-inactive.png
>rename to toolkit/themes/pinstripe/global/icons/panebutton-inactive.png
http://hg.mozilla.org/mozilla-central/rev/d05508ec2ab3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
(In reply to comment #5)
> (In reply to comment #4)
> > Why aren't your hg moves in the git diff? ;-)
> They are
D'oh, I forgot hg lists them in order of target location...
Depends on: 537697
You need to log in before you can comment on or make changes to this bug.