504353 - MethodInfo::verify needs some volatile qualifiers

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Steven Johnson]

Attachment: Patch

If the JIT throws an exception it tries to clean up coder -- but coder isn't marked as volatile and could be clobbered by the try/catch setmp.

Comment 1

[Edwin Smith]

Comment on attachment 388731 [details] [diff] [review]
Patch

Jeff says this isn't a complete fix

Comment 2

[Steven Johnson]

Comment on attachment 388731 [details] [diff] [review]
Patch

I am a bonehead and have misdiagnosed the bug here entirely. Entirely new patch coming up soon.

Comment 3

[Steven Johnson]

(In reply to comment #1)
> (From update of attachment 388731 [details] [diff] [review])
> Jeff says this isn't a complete fix

Not even a partial fix :-)

Comment 4

[Steven Johnson]

Attachment: Patch #2

Let's try this again, with a little placement-new love. 

(Also, existing code wouldn't compile with FEATURE_NANOJIT disabled... fixed that too)

Comment 5

[Edwin Smith]

Comment on attachment 388753 [details] [diff] [review]
Patch #2

suggest using intptr_t buffers (and scaling the size) to ensure proper alignment.  or this might work:

union {
   CodegenLIR foo
   char cogen_buf[sizeof(CodegenLIR)]
}

Comment 6

[Steven Johnson]

Attachment: Patch #3

Same as Patch #2 but with aligned buffers. (the union trick won't work, as union members can't have ctors)

Comment 7

[Steven Johnson]

pushed to redux as changeset:   2144:825a919d40ef

Comment 8

[Chris Peyer]

Resolved fixed engineering / work item that has been pushed.  Setting status to verified.