Closed Bug 504379 Opened 11 years ago Closed 11 years ago
Building NSPR for windows mobile complains about -O being deprecated
Building NSPR for windows mobile complains about -O being deprecated. I am using the Windows Mobile 6 SDK. We can easily move from -0 which is the default optimization setting for NSPR to -O1.
Attachment #388749 - Flags: review?(wtc)
Comment on attachment 388749 [details] [diff] [review] patch v.1 r=wtc. >+ _OPTIMIZE_FLAGS="-O1" You don't need to quote -O1. Are you sure -O1 is good enough? We're using -O2 for desktop Windows. See http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/nsprpub/configure.in&rev=1.260&mark=1543#1540
I built and tested with -O2. It did not make any noticeable difference running fennec. I think we would be happy with either change, but being consistent with desktop Windows is probably best.
wan-teh, what are the next steps here?
> what are the next steps here? You attach your -O2 CVS patch, it gets reviewed and committed. :)
Use -O2. I checked in this patch on the NSPR trunk (NSPR 4.8.1). Checking in configure.in; /cvsroot/mozilla/nsprpub/configure.in,v <-- configure.in new revision: 1.261; previous revision: 1.260 done Checking in configure; /cvsroot/mozilla/nsprpub/configure,v <-- configure new revision: 1.257; previous revision: 1.256 done
Doug, since this isn't a critical bug, we will push a new NSPR tag to mozilla-central when the need arises.
Status: NEW → RESOLVED
Closed: 11 years ago
OS: Windows XP → Windows Mobile 6 Standard
Hardware: x86 → ARM
Resolution: --- → FIXED
Target Milestone: --- → 4.8.1
Attachment #391401 - Flags: review?(doug.turner) → review+
You need to log in before you can comment on or make changes to this bug.