nsZipArchiveStandalone::BuildFileList leaks item when it reaches "truncated file"

RESOLVED FIXED

Status

()

Core
Networking: JAR
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({mlk})

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 obsolete attachment)

(Assignee)

Description

8 years ago
936     nsZipItem* item = CreateZipItem(namelen);
967     if (leftover < (namelen + extralen + commentlen + ZIPCENTRAL_SIZE)) {
974       if (byteCount < (namelen + extralen + commentlen + sizeof(sig))) {
975         // truncated file
976         return ZIP_ERR_CORRUPT;
... does not reach:
999     mFiles[hash] = item;
(Assignee)

Comment 1

8 years ago
Created attachment 388784 [details] [diff] [review]
patch
Attachment #388784 - Flags: review?(dveditz)

Comment 2

8 years ago
Fixed by bug 504864: This leak is now no longer there.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Attachment #388784 - Attachment is obsolete: true
Attachment #388784 - Flags: review?(dveditz)
You need to log in before you can comment on or make changes to this bug.