504427 - "blocking-1.9.1" pseudo-flag in the wrong place on enter_bug.cgi

Status: RESOLVED WORKSFORME

(bugzilla.mozilla.org :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

STR:

1) File a new (Camino) bug today
2) Notice that a flag-like "blocking-1.9.1" <select> appears in the left-hand column of the page, between the URL and the summary
3) Wonder why it does not appear on the right underneath/near the Flags column

The flag-like fields appear in, or close to, the correct location on filed bugs (https://bugzilla.mozilla.org/show_bug.cgi?id=504425), so they should appear in that location when filing, too.

Comment 1

[Gervase Markham [:gerv]]

All the custom fields are now correctly over on the right hand side.

Gerv

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Not on enter_bug.cgi; they're still on the left.

Comment 3

[David Lawrence [:dkl]]

This occurs cause the drop downs such as "blocking-1.9.1" are not really flags as far as Bugzilla is concerned and are actually custom fields created specifically for bugzilla.mozilla.org. The upstream enter_bug.cgi template groups all custom fields together in the same place which happens to be between URL and summary which is why they display where they do. These were not created originally as proper flags because they needed to have more possible values that a normal Bugzilla flag allows. So since upstream is unlikely to want to move the custom fields to the right, and bugzilla.mozilla.org strives to keep in sync with the upstream as much as possible, this is unlikely to change.

Dave

Comment 4

[Reed Loden [:reed]]

I see no reason why not to fix this... We do major changes to the edit page anyway.

Comment 5

[David Lawrence [:dkl]]

(In reply to comment #4)
> I see no reason why not to fix this... We do major changes to the edit page
> anyway.

That's fine but we will need to somehow be able to differentiate the flag-like custom fields from the non flag-like fields and just move those. Obviously we
can do some more regexp stuff in the templates but that will have to be updated anytime new flag custom fields are added. 

Unless we just move the whole custom field block to the right and not worry about filtering them.

Dave

Comment 6

[:glob ✱]

enter_bug got a sizable redesign some time ago; this has been addressed.