nsAttrAndChildArray::GrowBy worries coverity

RESOLVED FIXED

Status

()

defect
--
trivial
RESOLVED FIXED
10 years ago
5 months ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

(Blocks 1 bug, {coverity})

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment)

the code currently touches a pointer that has been realloc'd, which upsets coverity

it also spends time deciding if it should use Realloc or not, but it doesn't have to, realloc will act as malloc if passed a null in pointer:
http://www.mozilla.org/projects/nspr/reference/html/prmem2.html
Posted patch simplify codeSplinter Review
Attachment #388825 - Flags: review?(jonas)
Attachment #388825 - Flags: superreview+
Attachment #388825 - Flags: review?(jonas)
Attachment #388825 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/c9ae720fb05d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.