Closed Bug 504453 Opened 11 years ago Closed 11 years ago

nsAttrAndChildArray::GrowBy worries coverity

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file)

the code currently touches a pointer that has been realloc'd, which upsets coverity

it also spends time deciding if it should use Realloc or not, but it doesn't have to, realloc will act as malloc if passed a null in pointer:
http://www.mozilla.org/projects/nspr/reference/html/prmem2.html
Attached patch simplify codeSplinter Review
Attachment #388825 - Flags: review?(jonas)
Attachment #388825 - Flags: superreview+
Attachment #388825 - Flags: review?(jonas)
Attachment #388825 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/c9ae720fb05d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.