Closed Bug 504479 Opened 11 years ago Closed 11 years ago

nsSMILAnimationFunction::ScaleIntervalProgress Comparing unsigned less than zero is never true

Categories

(Core :: DOM: Core & HTML, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file)

600  	nsSMILAnimationFunction::ScaleIntervalProgress(double& aProgress,
601  	                                               PRUint32   aIntervalIndex,
602  	                                               PRUint32   aNumIntervals)

610  	  NS_ASSERTION(aIntervalIndex >= 0 && 

yes, that's always true

615  	  if (aIntervalIndex < 0 ||

that's never true

616  	      aIntervalIndex >= (PRUint32)mKeySplines.Length() ||
Attached patch patchSplinter Review
Attachment #388849 - Flags: review?(roc)
http://hg.mozilla.org/mozilla-central/rev/0f3738aad730
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.