504488 - nsXULElement::AfterSetAttr doesn't always guard its use of aValue

Status: NEW

(Core :: XUL, defect)

Description

[timeless]

in most places nsXULElement::AfterSetAttr checks aValue before using it....

Comment 1

[timeless]

Attachment: patch

mq diff's have limited context, here's the critical bit:
+            document && document->GetRootContent() == this &&
+            aValue) {
 
             nscolor color = NS_RGBA(0, 0, 0, 0);
             nsAttrValue attrValue;
             attrValue.ParseColor(*aValue, document);

Comment 2

[[e-mail]]

Comment on attachment 388858 [details] [diff] [review]
patch

Normal elements call AfterSetAttr with a null aValue from UnsetAttr. While they currently do not, it is possible that at some point that it would be desirable for XUL elements to call AfterSetAttr from UnsetAttr. I therefore consider that the code should either be written to mirror the work UnsetAttr does, or that it should not null-check aValue at all, however which it should be is not my call.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.