The search field on index.cgi is not cleared automatically when entering the field (IE 7 and older only)

RESOLVED FIXED in Bugzilla 3.4

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: p.verhoeven, Assigned: LpSolit)

Tracking

3.3.4
Bugzilla 3.4
All
Windows XP
Bug Flags:
approval +
approval3.4 +
blocking3.4 +

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; InfoPath.1; .NET CLR 2.0.50727)
Build Identifier: 

On the main page the search field contains the text "Enter a bug # or some search terms". When the field is entered this text is not automatically cleared.

Reproducible: Always

Actual Results:  
Start the main page in 3.4 RC1, click on the search field and enter some data. 

Expected Results:  
Search field should be empty after clicking the field
(Reporter)

Updated

9 years ago
Flags: blocking3.4?
(Reporter)

Comment 1

9 years ago
Only search field in the header isn't working. Search Field in the footer works fine.
(Assignee)

Comment 2

9 years ago
The problem only affects IE 6 and IE 7. All other browsers (IE 8, Firefox, Opera, Safari and Google Chrome) are working correctly. For some reason the "Enter a bug # or some search terms" text appears in the search field in the header instead of the main search field in the middle of index.cgi.

I checked, and the login + password fields are not affected by this problem.
Assignee: general → ui
Severity: major → normal
Status: UNCONFIRMED → NEW
Component: Bugzilla-General → User Interface
Ever confirmed: true
Hardware: x86 → All
Summary: Search field on mainpage in 3.4RC1 not empty automatically when entering the field → The search field on index.cgi is not cleared automatically when entering the field (IE 7 and older only)
Target Milestone: --- → Bugzilla 3.4
Version: unspecified → 3.3.4
(Assignee)

Comment 3

9 years ago
IE 6 and IE 7 behave incorrectly, per http://msdn.microsoft.com/en-us/library/ms536437%28VS.85%29.aspx

"Internet Explorer 8 and later. In IE8 mode, getElementById performs a case-sensitive match on the ID attribute only. In IE7 mode and previous modes, this method performs a case-insensitive match on both the ID and NAME attributes, which might produce unexpected results."

As all search fields have the same name (name="quicksearch"), IE 6 and IE 7 choose the first search field they find, i.e. the one in the header. They of course violate the W3C spec:

http://www.w3.org/TR/DOM-Level-2-Core/core.html#ID-getElBId
(Assignee)

Comment 4

9 years ago
Created attachment 388897 [details] [diff] [review]
patch, v1

The fix is trivial: just use another ID which doesn't match any name attribute. While I was on it, I also remove the quicksearch_help_text class which has nothing to do with the Account icon.
Assignee: ui → LpSolit
Status: NEW → ASSIGNED
Attachment #388897 - Flags: review?(guy.pyrzak)

Updated

9 years ago
Flags: blocking3.4? → blocking3.4+

Comment 5

9 years ago
Comment on attachment 388897 [details] [diff] [review]
patch, v1

looks good passing it to mkanat for 2nd look. Make sure to apply to head and to branch!
Attachment #388897 - Flags: review?(mkanat)
Attachment #388897 - Flags: review?(guy.pyrzak)
Attachment #388897 - Flags: review+
(Assignee)

Updated

9 years ago
Flags: approval3.4+
Flags: approval+

Updated

9 years ago
Attachment #388897 - Flags: review?(mkanat) → review+

Comment 6

9 years ago
Comment on attachment 388897 [details] [diff] [review]
patch, v1

Yeah, looks right to me.

Comment 7

9 years ago
By the way, I think that if a full reviewer asks a half-reviewer for review, the half-reviewer doesn't have to ask another person for review. (That is, your r+ is enough, on LpSolit's patch.)
(Assignee)

Comment 8

9 years ago
tip:

Checking in skins/standard/index.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/index.css,v  <--  index.css
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/index.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/index.html.tmpl,v  <--  index.html.tmpl
new revision: 1.45; previous revision: 1.44
done

3.4rc1:

Checking in skins/standard/index.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/index.css,v  <--  index.css
new revision: 1.10.2.1; previous revision: 1.10
done
Checking in template/en/default/index.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/index.html.tmpl,v  <--  index.html.tmpl
new revision: 1.44.2.1; previous revision: 1.44
done
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.