504574 - No install.js when creating .xpi files with new CCK

Status: RESOLVED INCOMPLETE

(Other Applications :: CCK, defect)

Description

[enorwood]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1) Gecko/20090624 (CK-UWDEOHS) Firefox/3.5 (.NET CLR 3.5.30729)
Build Identifier: CCK Wizard 1.2.5.1

I have made an .xpi with the CCK that sets some preferences for another add-on (foxyproxy). This is done in an .xpi so we can deploy it to all the computers in our dept. This worked fine in CCK version 1.2

I installed the newest CCK to make add-ons that are compatible with Firefox 3.5. However now when I create the same add on it causes browser problems, namely:

1) Icons in the lower right status bar disappear.
2) Firefox cannot open a new window or open a new instance.
3) When closing Firefox the process does not end, causing the 'hang on exit error' that says firefox is already running when you try to re-open.

This happens and has been tested consistently in Firefox 3.0.11 and in 3.5

I've compared the files in the old .xpi to the new one, and found that install.js is no longer in the new versions. Everything else is exactly the same, so I have to assume this is the reason. I also tried manually modifying the install.rdf in the old add-on to make it compatible with Firefox 3.5.* and this works fine.



Reproducible: Always

Steps to Reproduce:
1. Create add on that changes about:config settings in CCK.
The settings I'm adding / changing are this:

Name: extensions.foxyproxy.settings
Value (string): file:///C:/Documents%20and%20Settings/All%20Users/Application%20Data/Mozilla/Firefox/Profiles/foxyproxy.xml

Name: extensions.foxyproxy.last-version
Value(string): 999.999

2. Install add-on.


Actual Results:  
Browser is missing icons in lower right status bar. Browser will not open a new window from menu or from an html link. Will not open a new instance by running firefox.exe. When browser is closed, firefox.exe process does not end.

Expected Results:  
Normal browser functionality with settings applied.

We use WPKG as a software deployment tool. I first noticed this after deploying the add-on to some computers. However I was also able to recreate the error by manually installing the add-on.

Comment 1

[Benjamin Smedberg]

Install.js has not been used since Firefox 2... the symptoms you are describing must be from some other change.

Comment 2

[enorwood]

Ah, that was the only change that immediately stood out to me. I can continue to look for differences. I can also send you the two different files if you would like.

Another note of strange behavior, which I can put into a separate bug report if you want, is when running the CCK wizard. When I select a different add-on to modify, all the following steps retain the same values as the last add-on I ran the wizard for and completed. I don't remember this happening in the earlier version of the CCK I was using.

Comment 3

[Mike Kaply [:mkaply]]

Two XPIs to compare would be very helpful.

Comment 4

[enorwood]

Attachment: This was made with the older CCK and works

Comment 5

[enorwood]

Attachment: This was made with the newer CCK and causes the error.

Comment 6

[enorwood]

I've attached the two .xpi files. Note: in the older working version I manually changed the install.rdf for compatibility with Firefox 3.5.*. This is the only change I made to this file (and it still works in my test cases).

I have some additional information as well. We had a separate .xpi for adding our university's security certificate to Firefox. I hadn't tried the version with the new CCK yet as I was afraid of having the same issues. However I tested the new one and it seems to work ok, none of the Firefox errors I encountered before.

Comment 7

[Mike Kaply [:mkaply]]

This got lost in the shuffle.

I'm trying to recreate this and not seeing it with the XPIs you gave me.

Is Foxy proxy basic or standard installed when this is happening?

Comment 8

[Mike Kaply [:mkaply]]

Closed for no response. If you can still recreate, please reopen.