Closed
Bug 504603
Opened 15 years ago
Closed 15 years ago
Investigate if 'This answer solved my problem' feature is p12n compatible
Categories
(support.mozilla.org :: Knowledge Base Software, task)
support.mozilla.org
Knowledge Base Software
Tracking
(Not tracked)
VERIFIED
FIXED
1.3
People
(Reporter: ecooper, Assigned: paulc)
References
()
Details
(Whiteboard: enable pref sumo_only)
Attachments
(1 file)
6.11 KB,
patch
|
laura
:
review+
|
Details | Diff | Splinter Review |
While patching up bug 480585, I found that the 'This answer solved my problem' feature and most things related to it aren't exactly p10n friendly. For example, see <https://bugzilla.mozilla.org/show_bug.cgi?id=480585#c8> We need to either merge this into the special 'thread_statuses' feature or into its own feature. ATM, it may not work as it's supposed to with a different group with different forums on a different platform.
Assignee | ||
Comment 1•15 years ago
|
||
* adds 2 prefs: one that enables the feature and one that specifies for which forum IDs it's shown * removes 2 hard-coded forumId == 1 instances found while searching for this feature With this we should be able to better control if and where it shows up on forums, and which forums.
Assignee: smirkingsisyphus → paul.craciunoiu
Attachment #394132 -
Flags: review?(smirkingsisyphus)
Attachment #394132 -
Flags: review?(laura)
Updated•15 years ago
|
Attachment #394132 -
Flags: review?(laura) → review+
Assignee | ||
Comment 2•15 years ago
|
||
Comment on attachment 394132 [details] [diff] [review] patch, v1 r49648 / r49649 And enabled the pref on stage.
Attachment #394132 -
Flags: review?(smirkingsisyphus)
Assignee | ||
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: enable pref
Comment 3•15 years ago
|
||
Verified FIXED on https://support-stage.mozilla.org/tiki-view_forum_thread.php?forumId=1&comments_parentId=421703#mark (en-US feature hasn't regressed, at least).
Status: RESOLVED → VERIFIED
Updated•15 years ago
|
Summary: Investigate if 'This answer solved my problem' feature is p10n compatible → Investigate if 'This answer solved my problem' feature is p12n compatible
Whiteboard: enable pref → enable pref sumo_only
You need to log in
before you can comment on or make changes to this bug.
Description
•