504611 - NSS 3.12.3.1 release

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement, P1)

Description

[Wan-Teh Chang]

Attachment: Proposed patch (on top of NSS_3_12_3_WITH_CKBI_1_75_RTM )

We should create a NSS 3.12.3.1 release, with CVS tag
NSS_3_12_3_1_RTM, to identify the NSS in Firefox 3.5.1.  It
should be based on the CVS tag NSS_3_12_3_WITH_CKBI_1_75_RTM
plus the fixes for these bugs:
- bug 494302: Stop building CAPI module in Firefox builds
- bug 501605: very slow startup for Firefox 3.5 due to
  accessing IE Internet Temporary Files and Windows Temp
  folder
- bug 489811: RNG_SystemInfoForRNG called twice by
  nsc_CommonInitialize

The version strings in the shared libraries (except libnssckbi.so)
should say "3.12.3.1".

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Wan-Teh, on what branch would you make these proposed changes?
It's too late for the trunk.  
Personally, I don't want to create a branch for this purpose.
I don't want to give anyone the idea that they can ask us to make more
releases between 3.12.3 and 3.12.4.  

(BTW, we were discussing this very topic in this morning's week conference
call at the same time you were posting this bug.)

Comment 2

[Wan-Teh Chang]

I will create a mini branch rooted at NSS_3_12_3_WITH_CKBI_1_75_RTM
just for this 3.12.3.1 release.

I propose this release to reflect the reality -- Firefox 3.5.1
will be shipping with a variant of NSS 3.12.3 as described in
comment 0, and that version of NSS will make it into the NSS
package in some Linux distributions.  So we need to assign a
version number to it.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 388946 [details] [diff] [review]
Proposed patch (on top of NSS_3_12_3_WITH_CKBI_1_75_RTM
)

r=nelson for committing on a new branch.  Be sure to create a base tag, too.

Comment 4

[Wan-Teh Chang]

Comment on attachment 388946 [details] [diff] [review]
Proposed patch (on top of NSS_3_12_3_WITH_CKBI_1_75_RTM
)

I created the NSS_3_12_3_MINIBRANCH, rooted at the
CVS tag NSS_3_12_3_BASE (the same as
NSS_3_12_3_WITH_CKBI_1_75_RTM).  The term "mini branch"
suggests that the branch is used for a single release.

I checked in this patch on the NSS_3_12_3_MINIBRANCH.

Checking in coreconf/coreconf.dep;
/cvsroot/mozilla/security/coreconf/coreconf.dep,v  <--  coreconf.dep
new revision: 1.2.2.1; previous revision: 1.2
done
Checking in nss/lib/ckfw/Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/Makefile,v  <--  Makefile
new revision: 1.16.2.1; previous revision: 1.16
done
Checking in nss/lib/freebl/win_rand.c;
/cvsroot/mozilla/security/nss/lib/freebl/win_rand.c,v  <--  win_rand.c
new revision: 1.24.2.1; previous revision: 1.24
done
Checking in nss/lib/nss/nss.h;
/cvsroot/mozilla/security/nss/lib/nss/nss.h,v  <--  nss.h
new revision: 1.64.2.1; previous revision: 1.64
done
Checking in nss/lib/softoken/pkcs11.c;
/cvsroot/mozilla/security/nss/lib/softoken/pkcs11.c,v  <--  pkcs11.c
new revision: 1.165.2.1; previous revision: 1.165
done
Checking in nss/lib/softoken/softkver.h;
/cvsroot/mozilla/security/nss/lib/softoken/softkver.h,v  <--  softkver.h
new revision: 1.8.2.1; previous revision: 1.8
done
Checking in nss/lib/util/nssutil.h;
/cvsroot/mozilla/security/nss/lib/util/nssutil.h,v  <--  nssutil.h
new revision: 1.2.2.1; previous revision: 1.2
done

Comment 5

[Wan-Teh Chang]

Attachment: Backport the fix for bug 487567

To avoid a build regression from NSS_3_12_2_WITH_CKBI_1_75_RTM,
which Firefox 3 is using, I have to backport the fix for bug 504611.

Checking in os2_rand.c;
/cvsroot/mozilla/security/nss/lib/freebl/os2_rand.c,v  <--  os2_rand.c
new revision: 1.8.2.1; previous revision: 1.8
done

This patch is already manually applied to mozilla-1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9e13c6ee8629

We really need to get everyone to update NSS in Hg with official
NSS tags:
https://developer.mozilla.org/en/Updating_NSPR_or_NSS_in_mozilla-central

Comment 6

[Wan-Teh Chang]

Comment on attachment 390966 [details] [diff] [review]
Backport the fix for bug 487567

I got the OS/2 bug number wrong.  It should be bug 487567.

Comment 7

[Wan-Teh Chang]

I have created the CVS tag NSS_3_12_3_1_RTM.  You can safely
drop it into the Firefox 3 CVS repository or the mozilla-1.9.1
Hg repository.

Comment 8

[Daniel Veditz [:dveditz]]

The 1.8 branch is using the 3.12.1-rtm tag, marking fixed.