Contributions don't work without a suggested amount, but the devcp contribution page doesn't make that clear

VERIFIED FIXED in 5.0.8

Status

addons.mozilla.org Graveyard
Public Pages
P1
normal
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: jbalogh, Assigned: jbalogh)

Tracking

unspecified
5.0.8

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
"You are currently asking for contributions" shouldn't turn on until everything is good to go.
(Assignee)

Updated

9 years ago
Priority: -- → P2
select count(id) from addons where wants_contributions=1 and suggested_amount="";
+-----------+
| count(id) |
+-----------+
|         5 | 
+-----------+

Is that this bug?
(Assignee)

Comment 2

9 years ago
Yes.
Priority: P2 → P1
(Assignee)

Comment 3

9 years ago
@nick: do we want to allow contributions without the suggested amount?  Devs would get the big blue button but have it go straight to paypal without a suggested amount.
I am ok with this.
So to be clear- yes, let's allow contributions with an amount of 0.
uh, I mean an amount of "", 0 is a bit weird...
(Assignee)

Comment 7

9 years ago
Created attachment 390862 [details] [diff] [review]
let contributions work without a suggested amount
Attachment #390862 - Flags: review?(clouserw)
Attachment #390862 - Flags: review?(clouserw) → review+
Comment on attachment 390862 [details] [diff] [review]
let contributions work without a suggested amount

works.  We also don't seem to require a dev to choose a "where to ask" but it looks like it just defaults to #1.
(Assignee)

Comment 9

9 years ago
Thanks, r30512.

(In reply to comment #8)
> (From update of attachment 390862 [details] [diff] [review])
> We also don't seem to require a dev to choose a "where to ask" but it
> looks like it just defaults to #1.

Right.  If they have contributions turned on and a paypal ID we show the passive form.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: push-needed
Resolution: --- → FIXED
Verified, FIXED. 
Now, if you don't enter anything (empty value) in the 'Suggested Amount' field, then the 'Contribution' link on the add-ons details page still shows up.

https://preview.addons.mozilla.org/en-US/firefox/addon/9331
Status: RESOLVED → VERIFIED
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.