504688 - pseudo-protocols and external protocols no longer autocompleted

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We used to autocomplete about: (e.g., about:crashes), data:, and view-source: pseudo-protocols (but not javascript:, which I think is fine, and/or perhaps we specifically disabled at one point), as well as mailto:.  Now we don't.

We should re-enable support for these (pseudo-)protocols.

Comment 1

[timeless]

i actually love being able to use autocomplete of javascript: in camino. as long as it's only autocompleting things i've typed, what's the harm?

Comment 2

[timeless]

Camino Version 2.0b4pre (1.9.0.12pre 2009071000)

i can complete all of: about:, data:, view-source: in both the dialog and my urlbar.

Comment 3

[philippe (part-time)]

(In reply to comment #2)
> Camino Version 2.0b4pre (1.9.0.12pre 2009071000)

timeless, you need a more recent build :-)
20090716, Camino 2.1a1pre

---
But yeah, I miss autocomplete on about: URL's

Comment 4

[Stuart Morgan]

Dan, we probably just need to always try matching from the beginning of the URL, instead of only doing it when we don't try a post-scheme match.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: "better" protocols testcase

So, timeless is right about "javascript:"; we did autocomplete it *when typed manually*, and I had only been testing against clicked links (or bookmarks) when I started testing yesterday afternoon.

In fact, with the exception of "jar:", we didn't autocomplete any pseudo-protocol or external protocol unless the URI was typed manually in the location bar (and, also with the exception of jar:, these were hidden from history; see also bug 302601 for some somewhat-related discussion).

There's also a subtle regression in autocompleting internal protocols. "file://" URIs used to begin triggering autocomplete on 'f', whereas now you don't start getting matches until you've typed 'file://'.

For http/https URLs, we used to start autocompleting only on the first letter of the site/domain ('http://c'); now we start autocompleting after 'http://', which shows "random" results.

Comment 6

[Dan Weber]

(In reply to comment #5)
> There's also a subtle regression in autocompleting internal protocols.
> "file://" URIs used to begin triggering autocomplete on 'f', whereas now you
> don't start getting matches until you've typed 'file://'.
> 
> For http/https URLs, we used to start autocompleting only on the first letter
> of the site/domain ('http://c'); now we start autocompleting after 'http://',
> which shows "random" results.

I never really intended to reproduce the behavior of past versions of Camino exactly. My latest attempt uses just one regex test, instead of two. The magic string is this:

(.*://www\\.)?%@.*

This will match pseudo protocols*. It will also start matching as soon as you type in any letter and won't stop. So http:// still matches "random" results, which is fine with me. I'm open to any great ideas.

* Any pages beginning with about: don't show up in history. Others, such as file: and javascript: work fine. If you have about: pages bookmarked, they will show up in autocomplete, but otherwise they won't. Previous versions of Camino had the about: sites show up in autocomplete only during the session they were visited. I don't know why. Once you relaunched Camino, they were gone. This is also true for a few others, such as data:

Comment 7

[Dan Weber]

Perhaps the string should be (.*://)?(www\\.)?%@.*

Comment 8

[timeless]

well, i promise not to upgrade until you fix this bug ;-), i like my version of Camino :)

i have:
about:{,blank,cache,config,credits,plugins} in my completion. I highly doubt i've visited all of them in this session.

these are my data urls:
data:text/html,<img%20src="http://images.macdesktops.com/images/1280x1024/NasaSTS125Hubble1280x1024.jpg">
data:text/html,<textarea%20cols=100%20rows=50>
data:text/html,<textarea%20cols=100>
data:text/plain,nialp/txet:atad

I can assure you that i haven't typed that last one in ages, and i'd be rather surprised if it was a bookmark, since as things go it's not terribly useful.

If someone wants some files from my camino profile, i might be willing to share them (i'm slightly worry that they contain credentials...).

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Dan Weber from comment #6)
> * Any pages beginning with about: don't show up in history. Others, such as
> file: and javascript: work fine. If you have about: pages bookmarked, they
> will show up in autocomplete, but otherwise they won't. Previous versions of
> Camino had the about: sites show up in autocomplete only during the session
> they were visited. I don't know why. Once you relaunched Camino, they were
> gone. This is also true for a few others, such as data:

Stuart's method in bug 188178 comment 12 is probably the way to fix this (although we'd have to manage expiration ourselves in this case).