User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:22.214.171.124) Gecko/2009060308 Ubuntu/9.04 (jaunty) Firefox/3.0.11 Build Identifier: tip The configure.in file has the following: AC_ARG_ENABLE(threadsafe, [ --enable-threadsafe Enable support for multiple threads.], [AC_DEFINE(JS_THREADSAFE)],) The AC_DEFINE(JS_THREADSAFE) is used even if --disable-threadsafe is called. The enableval is set to no, but the value is defined anyway. A solution which might work better is as follows: AC_ARG_ENABLE(threadsafe, [ --enable-threadsafe Enable support for multiple threads.], [if test "x$enableval" = "xyes"; then AC_DEFINE(JS_THREADSAFE) fi],) This checks the value of enableval to see if it is yes and only sets the define if it is yes. Since threadsafe is disabled by default, it might also be good to show this in the --help listing. Reproducible: Always Steps to Reproduce: 1. Run autoconf2.13 2. Run ./configure --disable-threadsafe Actual Results: grep for JS_THREADSAFE and it is defined in js-config.h to be 1 Expected Results: JS_THREADSAFE should not be defined at all
Yes, I can reproduce it. Regards to https://developer.mozilla.org/en/JS_THREADSAFE, JS_THREADSAFE is always on (and sources are really built with -DJS_THREADSAFE). But without --enable-threadsafe config option the js-config.h file says JS_THREADSAFE is disabled.
Created attachment 634635 [details] [diff] [review] v0: copied from comment