50478 - Key events bubble, but report "bubbles=false"

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Taras Tielkes]

On both Windows and Linux, the "onkeydown" event has the "bubbles" property set 
to false, but bubbling works nontheless. The stopPropagation() method on the 
event object also has the expected effect.

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Nominating for nsbeta3. I am assuming the fix would be simple.

Comment 2

[Taras Tielkes]

Related to
http://bugzilla.mozilla.org/show_bug.cgi?id=50469

Comment 3

[Nisheeth Ranjan]

Re-assigning to Heikki and marking nsbeta3+

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Hmm. On further inspection it seems both bubbles and cancelable property return 
wrong values. It also looks like the implementation of GetBubbles and 
GetCancelable are implemented wrong:

250 nsDOMEvent::GetBubbles(PRBool* aBubbles)
251 {
252   *aBubbles = mEvent->flags & NS_EVENT_FLAG_CANT_BUBBLE;
253   return NS_OK;

Today is Monday, but it seem to me that line 252 should read:

   *aBubbles = !(mEvent->flags & NS_EVENT_FLAG_CANT_BUBBLE);

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Since P3 bugs will no longer be fixed, I am proposing a partial fix for this and 
then futuring. The partial fix is to correct the implementation of GetBubbles 
and GetCancelable. This basically reverses what the bubbles and cancelable 
propertie report now, but it reflects how we really deal with the events. It 
would be a much bigger job to set the bubbles & cancelable properties correctly 
for all events. Right now pretty much everything bubbles, regardless of the 
specs.

Comment 6

[Nisheeth Ranjan]

Marking relnote. See related bug 53118 for information about a known bug in
which Gecko bubbles events that should not be bubbled.

We will minus this bug once Heikki checks in his partial one-liner fix.

Comment 7

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Actually, this is now fixed because GetBubbles was fixed. This is more because 
of an accident - all of our events bubble. The only exception I know of right 
now is the load event when it is caused by image load. 

Bug 53118 is about events that bubble even though they shouldn't.

Comment 8

[Loco]

Updating QA Contact.

Comment 9

[Hixie (not reading bugmail)]

Reassigning QA Contact for all open and unverified bugs previously under Lorca's
care to Gerardo as per phone conversation this morning.

Comment 10

[Madhur Bhatia]

QA contact updated

Comment 11

[luis rincon]

verified on build 2001-08-07-08-trunk