Add explicit braces to if-statement, to fix build warning in nsContentBlocker.cpp

RESOLVED FIXED

Status

()

Core
Image Blocking
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 389201 [details] [diff] [review]
fix

When building nsContentBlocker.cpp, I get this compile warning:

/mozilla/extensions/permissions/nsContentBlocker.cpp: In member function ‘virtual nsresult nsContentBlocker::ShouldLoad(PRUint32, nsIURI*, nsIURI*, nsISupports*, const nsACString_internal&, nsISupports*, PRInt16*)’:
/mozilla/extensions/permissions/nsContentBlocker.cpp:184: warning: suggest explicit braces to avoid ambiguous ‘else’

The attached patch adds explicit braces and fixes this warning.
Attachment #389201 - Flags: review?(jst)
(Assignee)

Updated

8 years ago
Assignee: nobody → dholbert
Status: NEW → ASSIGNED

Updated

8 years ago
Attachment #389201 - Flags: superreview+
Attachment #389201 - Flags: review?(jst)
Attachment #389201 - Flags: review+
(Assignee)

Comment 1

8 years ago
Landed:
http://hg.mozilla.org/mozilla-central/rev/02ff5f05a1a6
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Whiteboard: [build_warning]
You need to log in before you can comment on or make changes to this bug.