Tests shouldn't pass if the file doesn't exist

VERIFIED FIXED in 5.0.8

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: clouserw, Assigned: rjwalsh)

Tracking

unspecified
5.0.8

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

9 years ago
If the file we're verifying doesn't exist the test suite gives it a pass on "general verification" and fails "no install.rdf present"

I don't think "general verification" should pass if the file doesn't exist.
(Assignee)

Comment 1

9 years ago
Created attachment 389220 [details] [diff] [review]
Added file exists test to general tests
Attachment #389220 - Flags: review?(clouserw)
(Reporter)

Updated

9 years ago
Attachment #389220 - Flags: review?(clouserw) → review+
(Assignee)

Comment 2

9 years ago
Fixed in revision 29964
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Created attachment 390387 [details]
Post-fix screenshot; WFM
Attachment #390387 - Attachment is obsolete: true
Comment on attachment 390387 [details]
Post-fix screenshot; WFM

wrong bug; I am _so_ epic today
Created attachment 392375 [details]
Post-fix screenshot, showing validation failure due to missing file(s)
Verified FIXED; see above screenshot.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.