Closed Bug 504954 Opened 11 years ago Closed 11 years ago

Add Outbox to smart folders

Categories

(Thunderbird :: Folder and Message Lists, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b4

People

(Reporter: Bienvenu, Assigned: bwinton)

Details

(Whiteboard: [no l10n impact])

Attachments

(1 file, 3 obsolete files)

Even though there's only one Outbox, under Local Folders, it makes sense for it to appear in Smart Folders, so that all the special folders show up...
I'm thinking that this might block making the smart folders pane "complete".
Flags: blocking-thunderbird3?
Assignee: bienvenu → bwinton
Status: NEW → ASSIGNED
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Whiteboard: [no l10n impact]
Was something like this what you had in mind?

Thanks,
Blake.
Attachment #397316 - Flags: ui-review?(clarkbw)
Attachment #397316 - Flags: review?(bienvenu)
Whiteboard: [no l10n impact] → [no l10n impact][needs review bienvenu][needs ui-review clarkbw]
so, there's only one Outbox, so it seems silly to have a top-level smart Outbox, with a single sub-folder. We've talked about doing converse smart folders, where we show the outgoing messages for each account in a saved search, though that's not completely useful since it's all or nothing at send time...
All I think we need is to have the outbox be a toplevel thing in Smart folder mode -- it need not be implemented _as_ a smart folder.
yup, that's what I would do - but the patch as it stands now doesn't do that...
Attachment #397316 - Flags: review?(bienvenu) → review-
Whiteboard: [no l10n impact][needs review bienvenu][needs ui-review clarkbw] → [no l10n impact][needs new patch][needs ui-review clarkbw]
(In reply to comment #5)
> yup, that's what I would do - but the patch as it stands now doesn't do that...

Okay, I think I can whip up a patch that does do that.

Thanks,
Blake.
So, instead of special-casing Outbox, I made any smart folder that only contains a single folder get pushed up to the root.  The other folder in my setup that it affects is the Junk folder, and I think I prefer the new behaviour.

Thanks,
Blake.
Attachment #397316 - Attachment is obsolete: true
Attachment #397773 - Flags: ui-review?(clarkbw)
Attachment #397773 - Flags: review?(bienvenu)
Attachment #397316 - Flags: ui-review?(clarkbw)
Whiteboard: [no l10n impact][needs new patch][needs ui-review clarkbw] → [no l10n impact][needs review bienvenu][needs ui-review clarkbw]
looks reasonable - but what happens when a 2nd folder is added, e.g., in your case, if you were to add a second junk folder?
I added a second junk folder, then went back to the Smart Folders list, and the top-level Junk folder appeared as a smart folder, with two sub-items, Home and UofT, which seemed correct.

If I was on the Smart Folders list, and edited the UofT settings to move all mail to the Junk folder, then I needed to switch away from and back to the Smart Folders view to get it to show up.

Would it be reasonable to live with this behaviour for 3.0, and fix it as part of 3.1?
Comment on attachment 397773 [details] [diff] [review]
A patch to add the Outbox, and make folders with only one sub-folder just appear in the root.

Looks good. Personally, I think I'd like Outbox last in the list, because I never need to see it, but I'll leave that up to Bryan. I think for that to happen, we'd need to tweak nsMsgDBFolder::GetSortOrder.

If our outbox was more than just unsent messages, I could imagine having it be higher up on the list.
Attachment #397773 - Flags: review?(bienvenu) → review+
Whiteboard: [no l10n impact][needs review bienvenu][needs ui-review clarkbw] → [no l10n impact][needs ui-review clarkbw]
(In reply to comment #10)
> (From update of attachment 397773 [details] [diff] [review])
> Looks good. Personally, I think I'd like Outbox last in the list, because I
> never need to see it, but I'll leave that up to Bryan. I think for that to
> happen, we'd need to tweak nsMsgDBFolder::GetSortOrder.

Agreed, it does seem like a last in the list item.
(In reply to comment #10)
> Looks good. Personally, I think I'd like Outbox last in the list, because I
> never need to see it, but I'll leave that up to Bryan. I think for that to
> happen, we'd need to tweak nsMsgDBFolder::GetSortOrder.

I think I can make a simpler change that'll put it last in the list.  :)

Now, I assumed you meant last in the list of everything.  If you meant just before the accounts, let me know, and I'll fix it up.

Thanks,
Blake.
Attachment #397773 - Attachment is obsolete: true
Attachment #397990 - Flags: ui-review?(clarkbw)
Attachment #397773 - Flags: ui-review?(clarkbw)
I meant the last smart folder, before the first account. But Bryan's opinion is the one that counts :-)

Tweaking nsMsgDBFolder::GetSortOrder is a very simple change, two lines, most likely.
Yeah, sorry to be vague there.  I meant last of the smart folders as well.
Comment on attachment 397990 [details] [diff] [review]
The previous patch, with the Outbox moved.

tried it out, looks good so you can carry this forward with the other comment addressed.
Attachment #397990 - Flags: ui-review?(clarkbw) → ui-review+
Whiteboard: [no l10n impact][needs ui-review clarkbw] → [no l10n impact]
Okay, here we go.

Thanks,
Blake.
Attachment #397990 - Attachment is obsolete: true
Attachment #398061 - Flags: superreview?(bienvenu)
Whiteboard: [no l10n impact] → [no l10n impact][needs superreview bienvenu]
Comment on attachment 398061 [details] [diff] [review]
The previous patch, with the Outbox moved closer, but in more places.

looks good, thx.
Attachment #398061 - Flags: superreview?(bienvenu) → superreview+
Keywords: checkin-needed
Whiteboard: [no l10n impact][needs superreview bienvenu] → [no l10n impact]
Checked in: http://hg.mozilla.org/comm-central/rev/9a323dde5ffa
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.