Closed Bug 505015 Opened 16 years ago Closed 16 years ago

Selections are not persistent across submissions in the New Charts UI

Categories

(Bugzilla :: Reporting/Charting, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 3.4

People

(Reporter: LpSolit, Assigned: LpSolit)

Details

Attachments

(1 file)

Attached patch patch, v1Splinter Review
When you select a category/subcategory/name and click "Add to List", the selection is lost, despite the code in templates takes care of that. The reason is that it conflicts with JS. I fixed that. Also, I did some cleanup: - the same ID was used twice, making the page to not pass HTML4 tests; - I managed to use series_select for the 'name' select field thanks to a minor change in the template, avoiding code duplication between create-chart.html.tmpl and series-common.html.tmpl. I tested my patch with Firefox, Opera, Safari, Google Chrome and IE 6 + 8.
Attachment #389297 - Flags: review?(gerv)
Hi Frederic, I'm at OSCON this week, so may not get to this until the week after (together with the other review you asked me to do). Is that going to be a problem? Gerv
I guess it's not a problem as these bugs are here for years. :) It would be interesting to have a discussion on IRC when you are back to see what is important to improve/implement in the charting system. Have fun!
Attachment #389297 - Flags: review?(gerv) → review?(ghendricks)
Attachment #389297 - Flags: review?(ghendricks) → review+
Flags: approval3.4+
Flags: approval+
tip: Checking in template/en/default/reports/create-chart.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/create-chart.html.tmpl,v <-- create-chart.html.tmpl new revision: 1.18; previous revision: 1.17 done Checking in template/en/default/reports/series-common.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/series-common.html.tmpl,v <-- series-common.html.tmpl new revision: 1.6; previous revision: 1.5 done 3.4.1: Checking in template/en/default/reports/create-chart.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/create-chart.html.tmpl,v <-- create-chart.html.tmpl new revision: 1.16.4.1; previous revision: 1.16 done Checking in template/en/default/reports/series-common.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/series-common.html.tmpl,v <-- series-common.html.tmpl new revision: 1.5.4.1; previous revision: 1.5 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Summary: Selections are not persistent across submissions → Selections are not persistent across submissions in the New Charts UI
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: