Selections are not persistent across submissions in the New Charts UI

RESOLVED FIXED in Bugzilla 3.4

Status

()

--
minor
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: LpSolit, Assigned: LpSolit)

Tracking

Bugzilla 3.4
Bug Flags:
approval +
approval3.4 +

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 389297 [details] [diff] [review]
patch, v1

When you select a category/subcategory/name and click "Add to List", the selection is lost, despite the code in templates takes care of that. The reason is that it conflicts with JS. I fixed that.

Also, I did some cleanup:
- the same ID was used twice, making the page to not pass HTML4 tests;
- I managed to use series_select for the 'name' select field thanks to a minor change in the template, avoiding code duplication between create-chart.html.tmpl and series-common.html.tmpl.

I tested my patch with Firefox, Opera, Safari, Google Chrome and IE 6 + 8.
Attachment #389297 - Flags: review?(gerv)
Hi Frederic,

I'm at OSCON this week, so may not get to this until the week after (together with the other review you asked me to do). Is that going to be a problem?

Gerv
(Assignee)

Comment 2

9 years ago
I guess it's not a problem as these bugs are here for years. :) It would be interesting to have a discussion on IRC when you are back to see what is important to improve/implement in the charting system. Have fun!
(Assignee)

Updated

9 years ago
Attachment #389297 - Flags: review?(gerv) → review?(ghendricks)

Updated

9 years ago
Attachment #389297 - Flags: review?(ghendricks) → review+
(Assignee)

Updated

9 years ago
Flags: approval3.4+
Flags: approval+
(Assignee)

Comment 3

9 years ago
tip:

Checking in template/en/default/reports/create-chart.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/create-chart.html.tmpl,v  <--  create-chart.html.tmpl
new revision: 1.18; previous revision: 1.17
done
Checking in template/en/default/reports/series-common.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/series-common.html.tmpl,v  <--  series-common.html.tmpl
new revision: 1.6; previous revision: 1.5
done


3.4.1:

Checking in template/en/default/reports/create-chart.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/create-chart.html.tmpl,v  <--  create-chart.html.tmpl
new revision: 1.16.4.1; previous revision: 1.16
done
Checking in template/en/default/reports/series-common.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/series-common.html.tmpl,v  <--  series-common.html.tmpl
new revision: 1.5.4.1; previous revision: 1.5
done
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Summary: Selections are not persistent across submissions → Selections are not persistent across submissions in the New Charts UI
You need to log in before you can comment on or make changes to this bug.