Closed Bug 505032 Opened 10 years ago Closed 10 years ago

nsWifiScannerWin.cpp fails to compile on MinGW.

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

Fixed compilation on MinGW.
3.63 KB, patch
Biesinger
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1
Build Identifier: 

The main problem is that on MinGW wchar_t != unsigned short. It's easy to fix by using proper PRUnichar/WCHAR types. Also I get errors like:
error: comma at end of enumerator list
so I removed extra commas in enum types.

Reproducible: Always
Attachment #389316 - Flags: review?
Attachment #389316 - Flags: review? → review?(cbiesinger)
Assignee: nobody → jacek
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #389316 - Flags: review?(cbiesinger) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/945f97d56524

Thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.