50524 - Proxy|Prefs (manual) - default port should be blank, ! "0"

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Matthew T (active 1999-2002)]

Build: 2000082608, MacOS 9.0

To reproduce:
* Do a clean install of Mozilla.
* Start Mozilla.
* Open the Preferences dialog, and navigate to Advanced > Proxies.

What you see:
* In the `Manual proxy configuration' section, the port number field for each
  proxy is set to `0'.

What was expected:
* The port number fields should be blank until I enter values into them.

Comment 1

[sairuh (rarely reading bugmail)]

tever, d'you know which engineer would fix this --or would that be you, matt?
thx.

Comment 2

[matt]

i think we did this because it needed to be a number at sometime.
Will fix in all.js

Comment 3

[verah (gone)]

Nav triage team: [nsbeta3-]

Comment 4

[Stephen Walker]

Attachment: patch

Comment 5

[timeless]

bah. this will collide w/ my prefs reorg.

r=timeless, if you get it in before i land my changes. if not this patch earns 
instant bitrot.

Comment 6

[Alec Flett]

ack! this is the WRONG way to fix this problem. You're changing the types of
these prefs to strings from integers. Please fix the pref PANEL not the prefs
themselves

Comment 7

[[e-mail]]

Yeah, we should change the display of 0 to blank in the panel.

Nobody's really going to run a proxy server off port 0 are they. Adding support
for port 0 would be an RFE anyhow, because Communicator and Mozilla both treat
port number 0 as "off".

Comment 8

[sairuh (rarely reading bugmail)]

->samir, moz0.9.5. needs updated patch.

Comment 9

[Peter Trudelle]

Mass-moving lower-priority 0.9.5 bugs off to 0.9.6 to make way for remaining
0.9.4/eMojo bugs, and MachV planning, performance and feature work. If you
disagree with any of these targets, please let me know.

Comment 10

[James Green]

Attachment: Use |null|, not |0| or |""|

Comment 11

[James Green]

Supplied patch should be what we're after. I wonder if perhaps we should set the
default http cache port to 8080, not null?

Comment 12

[Alec Flett]

Comment on attachment 52403 [details] [diff] [review]
Use |null|, not |0| or |""|

I don't see how this fixes the bug. the integer value of the pref should still be "0". What is the pref type after we change this value? a string?

Comment 13

[James Green]

And how can we achieve that? I'm not sure I know a code to say, "empty integer."
 I didn't observe any problems with the |null| setting.

Comment 14

[Samir Gehani]

Once we get a reviewed patch I can check it in.  

Comment 15

[Jonathan Nieder]

I'm not sure whether this should be fixed.

I read the zeroes in the default prefs as indicating that if I don't
change the port, my settings won't work.  (No proxy is going to be
listening to port zero.)  If there were just blank spaces in the default
prefs, I might assume that (as in some telnet clients) if I didn't enter
a port a reasonable default would be silently assumed.  For the HTTP
proxy, for example, I might leave the port field blank assuming that I
didn't have to enter '8080' if I had only been told the hostname of my
HTTP proxy.

Anyway, seeing a little zero now and then does not bother me so much.
If there is any reason that this should be changed, I will gladly play
around with the interface code.

Comment 16

[Jonathan Nieder]

Adding myself to the CC list.  Sorry for the spam

Comment 17

[benc]

-> networking

Comment 18

[Stefan Borggraefe]

Fixed via bug 257758.

Comment 19

[benc]

V/fixed:
1.8b1, Mac OS X
Jonathan: I don't think your objection is relevant here. People either set up
their proxies or someone gives them config info.

In either case, the configuration info would contain a hostname or port.

Comment 20

[Jonathan Nieder]

(In reply to comment #19)

Yes, you're right.

I don't know how I stumbled onto this bug, but I had decided that this was
something I could fix; then I examined the problem more closely and decided
fixing it wouldn't accomplish anything (i.e. I didn't see any costs or benefits
from the fix).  Sorry for my confusing comment.  In my use of Mozilla and
Firefox, this bug doesn't affect me at all.