patcher-config-bump.pl doesn't know how to add 'beta-dir' to the patcher config

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
beta-dir instructs patcher to put the 'beta' channel snippets in their own directory, which in turn lets use push 'release' and 'beta' snippets separately. This is an important feature for stable branches.
(Assignee)

Comment 1

9 years ago
Created attachment 392732 [details] [diff] [review]
set beta-dir when useBetaChannel is true

I rebumped 3.5.1 -> 3.5.2 starting from rev 1.31 (minus the beta-dir entry) and ended up with the exact same thing as rev 1.32 - so this should work.
Attachment #392732 - Flags: review?(nthomas)
(Assignee)

Updated

9 years ago
Priority: -- → P2
Comment on attachment 392732 [details] [diff] [review]
set beta-dir when useBetaChannel is true

The change looks good, but readability suffers by putting it right in the middle of that commented out code. Just move it above or below.
Attachment #392732 - Flags: review?(nthomas) → review+
(Assignee)

Comment 3

9 years ago
Created attachment 392925 [details] [diff] [review]
same code, moved to a better location

landed as changeset:   336:e6ca29eefb4a
Attachment #392732 - Attachment is obsolete: true
Attachment #392925 - Flags: checked-in+
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.