Directories should be lowercase

VERIFIED FIXED

Status

SeaMonkey
Installer
P5
trivial
VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: Henrik Gemal, Assigned: Sean Su)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

18 years ago
All other directories created by the installer are lowercase. So should 
"Plugins" and "Uninstall".
(Reporter)

Comment 1

18 years ago
Created attachment 13611 [details] [diff] [review]
Diff: "Uninstall" -> "uninstall"
(Reporter)

Comment 2

18 years ago
Not quite sure where "Plugins" gets created....?
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Priority: P3 → P5
(Reporter)

Comment 3

18 years ago
Sean: any chance you get this one in?
It's soo simple...
Keywords: patch, review
(Assignee)

Comment 4

18 years ago
I'll try to check this in sometime today.

Comment 5

18 years ago
sr=mscott
(Assignee)

Comment 6

18 years ago
fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

17 years ago
Uninstall folder is now called "uninstall"
Plugins folder is still called "Plugins"

I cant seems to find where the "Plugins" folder is created.

Comment 8

17 years ago
Marking verified -
If you still want to change the P in Plugins to a lowercase p, it's in the 
installation directory.
Status: RESOLVED → VERIFIED
(Reporter)

Comment 9

17 years ago
ktrina: could you give me a link to where the "Plugins" directory is created?
The only uppercase use I could find in
http://lxr.mozilla.org/mozilla/search?string=%22Plugins%22

is in the install script itself, writing to a registry key at
http://lxr.mozilla.org/mozilla/source/xpinstall/packager/windows/browser.jst#244

That doesn't seem like that would do it, because installing the null plugin from
the browser.jst should have already created that directory with a lower case.
(Reporter)

Comment 11

17 years ago
it's kind of weird. The "Plugins" directory gets created right after you press 
"Start Install". The only place I can find "Plugins" is:
http://lxr.mozilla.org/mozilla/source/xpinstall/src/nsInstallFolder.cpp#45

Is that use by the installer?
(Reporter)

Comment 12

17 years ago
Found it! Will attach a small patch. it's in:
http://lxr.mozilla.org/mozilla/source/xpinstall/packager/windows/config.it#783
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 13

17 years ago
over to Curt.
Assignee: ssu → curt
Status: REOPENED → NEW
Target Milestone: --- → mozilla0.9.8

Updated

17 years ago
Target Milestone: mozilla0.9.8 → ---
(Reporter)

Comment 14

16 years ago
Created attachment 72794 [details] [diff] [review]
to make dirs lowercase
Attachment #13611 - Attachment is obsolete: true
(Reporter)

Comment 15

16 years ago
Created attachment 108200 [details] [diff] [review]
patch to fix remaining issues
Attachment #72794 - Attachment is obsolete: true
Comment on attachment 108200 [details] [diff] [review]
patch to fix remaining issues

Requesting review for this patch
Attachment #108200 - Flags: review?(dveditz)
Reassign to ssu
Assignee: curt → ssu
Comment on attachment 108200 [details] [diff] [review]
patch to fix remaining issues

The Force Upgrade items are irrelevant, it's the Destination items that are
creating the paths. But this patch fixes the problem, sr=dveditz

Sean, please check the commercial config.it as well.
Attachment #108200 - Flags: superreview+
Attachment #108200 - Flags: review?(ssu)
Attachment #108200 - Flags: review?(dveditz)
(Assignee)

Updated

16 years ago
Attachment #108200 - Flags: review?(ssu) → review+

Comment 19

15 years ago
This bug has a patch with r/sr, has it been checked in?
(Reporter)

Comment 20

15 years ago
Sean: could you check this one in?
(Assignee)

Comment 21

15 years ago
patch checked in
Status: NEW → RESOLVED
Last Resolved: 18 years ago15 years ago
Resolution: --- → FIXED

Comment 22

15 years ago
verified 4/21 build
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → gbush
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.