505278 - nsWifiAccessPoint::GetSsid doesn't do what it thinks it does with embedded nulls

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

nsWifiAccessPoint::GetSsid contains the following code:

  // just assign and embedded nulls will truncate resulting
  // in a displayable string.

  nsString tempStr;
  tempStr.AssignWithConversion(mSsid, mSsidLen);
  aSsid = tempStr;


I don't think this does what the comment says it does with embedded nulls; AssignWithConversion uses the passed in length as the length of the data, so I think this can include embedded nulls in the result.  If you want to get rid of embedded nulls, you probably just want to ignore mSsidLen and do:

  CopyASCIIToUTF16(mSsid, aSsid);

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/6a26645dc206

Comment 3

[Samuel Sidler (old account; do not CC)]

Comment on attachment 389831 [details] [diff] [review]
patch v.1

Not for 1.9.1.2.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 389831 [details] [diff] [review]
patch v.1

Approved for 1.9.1.4, a=dveditz for release-drivers

Comment 5

[Doug Turner (:dougt)]

landing on 1.9.1.x will require code changes.  We added tests cases that will fail without them.  If we are interested, i can match what we have on 1.9.2

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 389831 [details] [diff] [review]
patch v.1

past code-freeze for 1.9.1.4, removing non-blocker approval.