50529 - Leaking nsImapProtocol objects again

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect, P2)

Description

[David :Bienvenu]

nsImapProtocol objects are leaking - startup with inbox, and shutdown, we leak
an nsImapProtocol.

Comment 1

[David :Bienvenu]

I have a theory about this - I believe the root cause is that we're leaking
nsStreamListenerEvent's, and this in turn is caused by the way we shutdown
connections. We just blast out a logout to the output stream, on the UI thread,
and continue on our merry way shutting down. I believe this causes stream
listener events to get created, but not handled (I'm not sure why that would be,
but it's probably because we're not processing the data that comes back for the
logout and close responses from the server. To fix this, we could either try to
get hold of the socket directly and write to it, if that would stop necko from
getting involved at all, or we could do this "the right way" and actually run
urls to shut down, and wait for the to finish before shutting down (this is
slower, and could cause a delay, if the server is down, for example).

Comment 2

[lchiang]

- per mail triage

Comment 3

[David :Bienvenu]

nominating as a performance bug, since leaking memory will slow down
performance. I think fixing bug 58657 will fix this.

Comment 4

[scottputterman]

58657 is fixed. Are we still leaking?

Comment 5

[scottputterman]

marking nsbeta1-

Comment 6

[dprice (gone)]

any chance of getting this by .9?

Comment 7

[David :Bienvenu]

Attachment: proposed fix

Comment 8

[David :Bienvenu]

cancelling the outstanding read request seems to clean up the leak of
nsImapProtocol objects, at least in the simple case. I'll need to try this at
home, and I need to make sure we're still sending the logout command to the server

Comment 9

[Scott MacGregor]

Comment on attachment 50803 [details] [diff] [review]
proposed fix

sr=mscott

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 50803 [details] [diff] [review]
proposed fix

r=sspitzer

Comment 11

[David :Bienvenu]

there are still cases where we leak the protocol objects, but in the basic case
of starting up and shutting down, we don't leak anymore. Woo woo!

Comment 12

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Leak log with Win32 CVS (pulled @11:30 pm, 9-25)

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

<Dr. Evil>"We're hip, we're cool, tucca-tucca-tucca".

Verified FIXED ;-)