50540 - Clicking on [x] in Extracting dialog doesn't do anything

Status: RESOLVED WORKSFORME

(SeaMonkey :: Installer, defect, P2)

Description

[Henrik Gemal]

If you're really fast and click on the close button [x] in the upper right 
corner in the Extracting dialog you'd expect that the installer quits, but it 
doesn't. Is this button hooked up to anything or is it just there...?

Comment 1

[Sean Su]

it shouldn't do anything because there's currently no way to cancel out of that
part.

Curt, you should try to disable that checkbox.  The fix should be in nsinstall.

Comment 2

[Andreas Kunz]

Attachment: patch: remove WS_SYSMENU style

Easy patch, will compile and test before requesting review.

Comment 3

[Andreas Kunz]

Comment on attachment 139470 [details] [diff] [review]
patch: remove WS_SYSMENU style

Requesting r= from bsmedberg.

Due to bug 215864 I unfortunately cannot test this. However, the change is
small, obvious and only affects a window that is only visible a few seconds
before vanishing again, so this should not cause problems.
Of course this should still be tested, but because I can't, maybe you can do
it... :-/

Comment 4

[Andreas Kunz]

Now that I found a way to work around bug 243616 (successor of bug 215864), I
tested this patch and it works. So I'd appreciate a review...

Comment 5

[Sean Su]

Comment on attachment 139470 [details] [diff] [review]
patch: remove WS_SYSMENU style

works great!

r=ssu

Comment 6

[Thomas]

According to Comment #5 (Sean Su), this works great!
Can't this be closed/reviewed/implmented then?

Comment 7

[Thomas]

About half a year ago this was marked as working, can somebody who can review
this bug? (or at least change the target milestone? :p)

Comment 8

[Andreas Kunz]

Well, this patch is still waiting for the superreview needed for applying the
patch. :-/
If you know a more responsive Installer superreviewer, feel free to change the
sr request...

Comment 9

[Matthias Versen [:Matti]]

Seamonkey and Firefox are using a new NSIS based installer. resolving this old bug, please reopen if you still get this with the new installer