Closed
Bug 505430
Opened 15 years ago
Closed 15 years ago
County returned instead of country in geolocated address
Categories
(Core :: DOM: Geolocation, defect)
Core
DOM: Geolocation
Tracking
()
RESOLVED
FIXED
People
(Reporter: glazou, Assigned: dougt)
Details
Attachments
(1 file)
|
1.41 KB,
patch
|
glazou
:
review+
|
Details | Diff | Splinter Review |
Doug, there's an error in http://mxr.mozilla.org/mozilla-central/source/dom/src/geolocation/NetworkGeolocationProvider.js#98 That line should show |address.country,| and not |address.county,|. I detected it because I had weird results for country. Side note, I also always have a null streetNumber but it could be what returns the google API...
|
Assignee | |
Comment 1•15 years ago
|
||
this should fix it. could you give it a try and confirm.
Attachment #389700 -
Flags: review?
|
|
Assignee | |
Updated•15 years ago
|
Attachment #389700 -
Flags: review? → review?(daniel)
|
|
Assignee | |
Comment 3•15 years ago
|
||
joel filed bug 482260, but not much progress has been made. fwiw, google gears is donating their test suite as part of the w3c standards process. We will review and include their suite as part of our testing. This should happen before Nov (our next face to face).
|
Reporter | |
Comment 4•15 years ago
|
||
Comment on attachment 389700 [details] [diff] [review] patch v.1 tested, running now ok with that patch in; r=daniel@glazman.org
Attachment #389700 -
Flags: review?(daniel) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b7a348797168
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•