Closed
Bug 505490
Opened 15 years ago
Closed 15 years ago
Bug.comments and Bug.attachments should have "ids" instead of "bug_ids"
Categories
(Bugzilla :: WebService, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.4
People
(Reporter: mkanat, Assigned: mkanat)
Details
Attachments
(1 file)
|
3.15 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
LpSolit and I were talking, and we've decided that the Bug.comments method should take an "ids" argument for bug ids, instead of a "bug_ids" parameter--the consistency is more important than the clarity.
Flags: blocking3.4+
|
Assignee | |
Updated•15 years ago
|
Target Milestone: --- → Bugzilla 3.4
|
|
Assignee | |
Comment 1•15 years ago
|
||
I also noticed Bug.attachments has the same problem (which I authorized, but am changing my mind about now).
Summary: Bug.comments should have "ids" instead of "bug_ids" → Bug.comments and Bug.attachments should have "ids" instead of "bug_ids"
|
|
Assignee | |
Comment 2•15 years ago
|
||
|
||
Comment 3•15 years ago
|
||
Comment on attachment 389723 [details] [diff] [review] v1 I didn't test (QA tests will do it for me), but this looks good. r=LpSolit
Attachment #389723 -
Flags: review?(LpSolit) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
tip: Checking in Bugzilla/WebService/Bug.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm,v <-- Bug.pm new revision: 1.41; previous revision: 1.40 done 3.4: Checking in Bugzilla/WebService/Bug.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm,v <-- Bug.pm new revision: 1.33.2.5; previous revision: 1.33.2.4 done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: approval3.4+
Flags: approval+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•