If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Bug.comments and Bug.attachments should have "ids" instead of "bug_ids"

RESOLVED FIXED in Bugzilla 3.4

Status

()

Bugzilla
WebService
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

3.3.4
Bugzilla 3.4
Bug Flags:
approval +
approval3.4 +
blocking3.4 +

Details

Attachments

(1 attachment)

v1
3.15 KB, patch
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
LpSolit and I were talking, and we've decided that the Bug.comments method should take an "ids" argument for bug ids, instead of a "bug_ids" parameter--the consistency is more important than the clarity.
Flags: blocking3.4+
(Assignee)

Updated

8 years ago
Target Milestone: --- → Bugzilla 3.4
(Assignee)

Comment 1

8 years ago
I also noticed Bug.attachments has the same problem (which I authorized, but am changing my mind about now).
Summary: Bug.comments should have "ids" instead of "bug_ids" → Bug.comments and Bug.attachments should have "ids" instead of "bug_ids"
(Assignee)

Comment 2

8 years ago
Created attachment 389723 [details] [diff] [review]
v1
Assignee: webservice → mkanat
Status: NEW → ASSIGNED
Attachment #389723 - Flags: review?(LpSolit)

Comment 3

8 years ago
Comment on attachment 389723 [details] [diff] [review]
v1

I didn't test (QA tests will do it for me), but this looks good. r=LpSolit
Attachment #389723 - Flags: review?(LpSolit) → review+
(Assignee)

Comment 4

8 years ago
tip:

Checking in Bugzilla/WebService/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm,v  <--  Bug.pm
new revision: 1.41; previous revision: 1.40
done

3.4:

Checking in Bugzilla/WebService/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm,v  <--  Bug.pm
new revision: 1.33.2.5; previous revision: 1.33.2.4
done
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: approval3.4+
Flags: approval+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.