Closed Bug 505568 Opened 15 years ago Closed 15 years ago

jsshell should use the public api for property iteration

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file, 1 obsolete file)

patch
758 bytes, patch
timeless
: review+
Details | Diff | Splinter Review 
In order to build jsdb and other things jsshell needs to not rely on private features. using scope directly results in pulling in a class which doesn't work.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #389788 -
        Flags: review?(mrbkap)

    
    

    
  
Comment on attachment 389788 [details] [diff] [review]
patch

>+    sprop = 0;

Sorry I missed this before, but please use NULL here.

        Attachment #389788 -
        Flags: review?(mrbkap) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #389788 -
        Attachment is obsolete: true

        Attachment #389796 -
        Flags: review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/94c20779c378
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: